Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Open in OSM" in context menu #403

Merged
merged 1 commit into from
Jan 1, 2025
Merged

"Open in OSM" in context menu #403

merged 1 commit into from
Jan 1, 2025

Conversation

graue
Copy link
Contributor

@graue graue commented Dec 21, 2024

It opens OpenStreetMap.org in a new tab, useful for looking at how something is tagged - mostly only for us for development.

image

@graue graue merged commit c7bb847 into main Jan 1, 2025
3 checks passed
@graue graue deleted the graue/open-in-osm branch January 1, 2025 03:09
@abhumbla
Copy link
Contributor

abhumbla commented Jan 1, 2025

I guess in my head I had imagined that it would actually open up the way or someone so you could see the tags but I guess we don't have OSM IDs. if we're just opening it to the lat/lng, maybe we could link to cyclosm? or if there's an equivalent public transit OSM style?

https://www.cyclosm.org/#map=12/52.3728/4.8936/cyclosm

@graue
Copy link
Contributor Author

graue commented Jan 1, 2025

I don't see a feature to view node or way details on there. If you click "Edit the map," it just sends you to OSM.org. On OSM.org you can right click and "Query features" to find the specific node or way you want.

@abhumbla
Copy link
Contributor

abhumbla commented Jan 1, 2025

hmm then we should see if we can pass through edge IDs. might be useful to have for debug mode as well. then we can open the actual feature up, I doubt many people are going to query from point on mobile. either way, this is a good start

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants