Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be able to fetch region-specific info from API #293

Open
graue opened this issue Dec 15, 2023 · 0 comments · May be fixed by #388
Open

Be able to fetch region-specific info from API #293

graue opened this issue Dec 15, 2023 · 0 comments · May be fixed by #388
Assignees

Comments

@graue
Copy link
Contributor

graue commented Dec 15, 2023

Let's use the geoconfig endpoint added in bikehopper/bikehopper-web-app#21 to fetch all the information currently hardcoded in src/lib/region/

Since this has two downsides:

  1. Not able to localize the text via our existing translation system
  2. Slightly slows down app load with an additional API request on the critical path

We can optionally have a Bay Area override of some of the information remain hardcoded, while still serving the purpose of making it easier to set up an instance in a new region.

For an example geoconfig, request https://bikehopper.org/api/v1/config

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant