Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lint issues in region files #329

Closed
graue opened this issue Apr 30, 2024 · 1 comment
Closed

Fix lint issues in region files #329

graue opened this issue Apr 30, 2024 · 1 comment

Comments

@graue
Copy link
Contributor

graue commented Apr 30, 2024

The region files, src/lib/region/{BayArea,Chicagoland,LosAngeles}.jsx, violate lint rules:

  • react-refresh/only-export-components: They export a React component and also other stuff, so they break fast refresh in dev.
  • formatjs/no-literal-string-in-jsx: In the Chicago and Los Angeles region files, which are currently not used in production and only exist for testing locally, strings that appear in the UI are not localized.

This might be moot after we deal with #293, but if not, in some way we should fix those lints and remove the eslint-disable comments.
@graue graue mentioned this issue Apr 30, 2024
Merged
@graue
Copy link
Contributor Author

graue commented Oct 30, 2024

Getting rid of these files anyway

@graue graue closed this as not planned Won't fix, can't repro, duplicate, stale Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@graue