Merge pull request #104 from ampersarnie/hotfix/eslint-config

Correct the nested structure for eslint config

.circleci/config.yml

@@ -85,6 +85,11 @@ jobs:
             cd ./example-site/
             node ./../src/cli.js ci
           name: Run test - ci install projects
+      - run:
+          command: |
+            cd ./example-site/
+            node ./../src/cli.js build standards --once
+          name: Run test - Compile Standards Plugin
       - run:
           command: |
             cd ./example-site/

configs/eslint.js

@@ -13,7 +13,7 @@ module.exports = {
     es2021: true,
     node: true,
   },
-  extends: ['airbnb', 'prettier'],
+  extends: ['airbnb', 'prettier', 'plugin:@typescript-eslint/recommended'],
   parser: '@babel/eslint-parser',
   parserOptions: {
     requireConfigFile: false,
@@ -25,51 +25,48 @@ module.exports = {
       es2021: true,
       node: true,
     },
-    extends: ['airbnb', 'prettier', 'plugin:@typescript-eslint/recommended'],
-    parser: '@babel/eslint-parser',
-    parserOptions: {
-      requireConfigFile: false,
-      babelOptions: {
-        ...babelConfig,
-      },
-    },
-    plugins: ['@babel', 'react', 'prettier', 'jsdoc', 'import', '@typescript-eslint/eslint-plugin'],
     settings: {
       'import/resolver': eslintResolver(),
       'import/parsers': {
         '@typescript-eslint/parser': ['.ts', '.tsx'],
       },
     },
-    rules: {
-      complexity: ['error', 10],
-      'prettier/prettier': 'error',
-      'import/no-extraneous-dependencies': [
-        'error',
-        {
-          devDependencies: true,
-        },
-      ],
-      'react/jsx-uses-react': 'error',
-      'react/jsx-uses-vars': 'error',
-      'react/jsx-filename-extension': [1, { extensions: ['.js', '.jsx', '.ts', '.tsx'] }],
-      'react/react-in-jsx-scope': 0,
-      'react/prop-types': 0,
-      'react/forbid-prop-types': 0,
-      'react/require-default-props': 0,
-      'arrow-parens': 2,
-      'jsdoc/require-jsdoc': [
-        'error',
-        {
-          require: {
-            ArrowFunctionExpression: true,
-            ClassDeclaration: true,
-            ClassExpression: true,
-            FunctionDeclaration: true,
-            FunctionExpression: true,
-            MethodDefinition: true,
-          },
+  },
+  plugins: ['@babel', 'react', 'prettier', 'jsdoc', 'import', '@typescript-eslint/eslint-plugin'],
+  rules: {
+    complexity: ['error', 10],
+    'prettier/prettier': 'error',
+    'import/no-extraneous-dependencies': [
+      'error',
+      {
+        devDependencies: true,
+      },
+    ],
+    'react/jsx-uses-react': 'error',
+    'react/jsx-uses-vars': 'error',
+    'react/jsx-filename-extension': [
+      1,
+      {
+        extensions: ['.js', '.jsx', '.ts', '.tsx']
+      }
+    ],
+    'react/react-in-jsx-scope': 0,
+    'react/prop-types': 0,
+    'react/forbid-prop-types': 0,
+    'react/require-default-props': 0,
+    'arrow-parens': 2,
+    'jsdoc/require-jsdoc': [
+      'error',
+      {
+        require: {
+          ArrowFunctionExpression: true,
+          ClassDeclaration: true,
+          ClassExpression: true,
+          FunctionDeclaration: true,
+          FunctionExpression: true,
+          MethodDefinition: true,
         },
-      ],
-    },
-  }
-};
+      },
+    ],
+  },
+};

example-site/package.json

@@ -1,5 +1,6 @@
 {
     "name": "test-project",
+    "prettier": "./../configs/prettier",
     "eslintConfig": {
         "extends": "./../configs/eslint"
       },

example-site/plugins/standards/package.json

@@ -0,0 +1,9 @@
+{
+    "name": "standards",
+    "prettier": "./../../../configs/prettier",
+    "eslintConfig": {
+      "extends": "./../../../configs/eslint"
+    },
+    "dependencies": {},
+    "devDependencies": {}
+}

example-site/plugins/standards/src/entrypoints/jsx-standards.js

@@ -0,0 +1,15 @@
+/**
+ * A simple example for reproducing incorrect JSX issues
+ * in ESLint:
+ *  - react/react-in-jsx-scope
+ *  - react/jsx-filename-extension
+ */
+export default () => (
+  <div>
+    <ul>
+      <li>Item 1</li>
+      <li>Item 2</li>
+      <li>Item 3</li>
+    </ul>
+  </div>
+);

example-site/plugins/standards/tsconfig.json

@@ -0,0 +1,3 @@
+{
+    "extends": "../../../configs/tsconfig"
+}