Make Instant-Lyrics app-agnostic #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 1, 2017 17:55
|
allow me some time on this. |
simonbru
reviewed
Nov 6, 2017
| '(KHTML, like Gecko) Chrome/23.0.1271.64 Safari/537.11', | ||
| 'Accept-Language': 'en-US,en;q=0.8', | ||
| hdr = {'User-Agent': 'Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0', | ||
| 'Accept-Encoding': 'gzip, deflate, br', |
There was a problem hiding this comment.
On my side the request is not decoded correctly when enabling brötli.
Everything works fine again when changing this line to:
'Accept-Encoding': 'gzip, deflate',
|
This feature works well on my side after the fix I mentioned above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why restrict to Spotify lyrics? Instant-Lyrics is already using MPRIS, so it can be aware of music apps running. This is what my changes do:
I also corrected an encoding problem with accents.
This shows a summary of the changes:
