-
-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add QR Code to player #57
base: main
Are you sure you want to change the base?
Conversation
Hey, welcome and thanks for this! The main reason this feature hasn't been implemented (yet) is that I'd like it to be a bit more flexible, which depends on there being per-room settings, which don't exist yet. Once they do, I think these ideally should be configurable per-room:
It's a lot, I know, but users will (rightly) be picky about things on the screen all the time. This PR is a great reference for the core functionality though. Thanks again! |
Sure, I'll look into adding settings. This was just a really "get a QR code on there" sort of thing for now. I'll update the PR with a checklist of requirements. |
@bhj With regards to passing through the room password, What are your thoughts on using a nonce or short-term password for this? Would provide better security rather than passing the room password through to the client. It could work in a way that after the QR code is used it regenerates a new password & QR code, leaving the previous password(s) available for a period of time (in-case multiple people scan the same code). Basic steps would be:
Let me know if you think this is too complicated, or if you have any other thoughts on how this should work. |
@EffakT Very nice work! And wow, there are still more class-style components left than I thought 😮💨 Let's keep the QR password stuff simple for now (maybe just base64 it?). I guess the question is what this means for the QR payload size, and whether we need to enforce a max length for room passwords. |
Just a note to say I haven't forgotten about this; been working on some long-standing things on the server side. Thanks again for the contribution and patience! |
This adds a QR code to the bottom left of the player, using the
document.baseURI
as the URL for the QR code.Resolves #32