Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement BSON serialization Logic and Tests #34

Closed
wants to merge 1 commit into from

Conversation

7uperior
Copy link

This commit introduces several key components for BSON serialization:

  • Added SerBson.jl implementing the BSON deserialization interface.
  • Added test/Ser/SerBson.jl comprising tests for the serialization logic.
  • Updated test/runtests.jl to include BSON serialization tests.

These changes address tasks from issue #19, focusing on crafting a BSON serialization interface and developing a robust test suite

Pull request checklist

  • Did you bump the project version?
  • Did you add a description to the Pull Request?
  • Did you add new tests?
  • Did you add reviewers?

- Added `test/Ser/SerBson.jl` comprising tests for the serialization logic.
- Updated `test/runtests.jl` to include BSON serialization tests.
@7uperior 7uperior requested a review from gryumov as a code owner April 10, 2024 19:00
@dmitrii-doronin
Copy link
Contributor

Hello again, @7uperior! I am glad to see you're back so soon with a new commit. Let's work sequentially and finish with the first one. I'm sure you'll be able to make some improvements here afterwards and get merged pronto)

@dmitrii-doronin
Copy link
Contributor

I am closing this PR due to inactivity.

@7uperior
Copy link
Author

NP, I'll re-open or create a new one if necessary

@NeroBlackstone
Copy link
Contributor

NP, I'll re-open or create a new one if necessary

Thank you for providing the preliminary prototype implementation. Are you willing to reopen the PR or would you like others to implement it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants