Enhance error message readability

bhftbootcamp · Dec 16, 2024 · 5a56440 · 5a56440
1 parent 797552c
commit 5a56440
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 5 deletions.
diff --git a/src/De/De.jl b/src/De/De.jl
@@ -30,10 +30,17 @@ struct WrongType <: DeserError
 end
 
 function Base.show(io::IO, e::WrongType)
-    return print(
-        io,
-        "WrongType: for '$(e.maintype)' value '$(e.value)' has wrong type '$(e.key)::$(e.from_type)', must be '$(e.key)::$(e.to_type)'",
-    )
+    return if e.value == "Ptr{YYJSONVal}"
+            print(
+                io,
+                "WrongType: for '$(e.maintype)' got wrong type '$(e.key)::$(e.from_type)', must be '$(e.key)::$(e.to_type)'",
+            )
+        else
+            print(
+                io,
+                "WrongType: for '$(e.maintype)' value '$(e.value)' has wrong type '$(e.key)::$(e.from_type)', must be '$(e.key)::$(e.to_type)'",
+            )
+        end
 end
 
 include("Deser.jl")

diff --git a/test/deser.jl b/test/deser.jl
@@ -659,7 +659,7 @@ using Test, Dates
         end
 
         exp_str = """ {"correlation_id":2,"method":"subscribe.status","payload":{}} """
-        @test_throws "WrongType: for 'Message{Nothing}' value 'Ptr{YYJSONVal}' has wrong type 'payload::Dict{String, Any}', must be 'payload::Nothing'" Serde.deser_json(
+        @test_throws "WrongType: for 'Message{Nothing}' got wrong type 'payload::Dict{String, Any}', must be 'payload::Nothing'" Serde.deser_json(
             Message{Nothing},
             exp_str,
         )