Add min_y and max_y for left and right axes (#5)

Co-authored-by: artememelin <[email protected]>

Project.toml

@@ -1,6 +1,6 @@
 name = "LightweightCharts"
 uuid = "d6998af1-87ca-4e7f-83d4-864c79a249fa"
-version = "1.1.0"
+version = "1.2.0"
 
 [deps]
 Serde = "db9b398d-9517-45f8-9a95-92af99003e0e"

README.md

@@ -94,6 +94,8 @@ panel = lwc_panel(
         price_scale_id = LWC_RIGHT,
     );
     name = "ETHUSDT | Binance Spot",
+    right_max_y = 8000000,
+    left_min_y = 1000,
 )
 
 lwc_show(panel)

docs/src/index.md

@@ -84,6 +84,8 @@ panel = lwc_panel(
         price_scale_id = LWC_RIGHT,
     );
     name = "ETHUSDT | Binance Spot",
+    right_max_y = 8000000,
+    left_min_y = 1000,
 )
 
 lwc_show(panel)

frontend/dist/index_boundle.js.LICENSE.txt

@@ -1,6 +1,6 @@
 /*!
  * @license
- * TradingView Lightweight Charts™ v4.1.3
+ * TradingView Lightweight Charts™ v4.1.4
  * Copyright (c) 2024 TradingView, Inc.
  * Licensed under Apache License 2.0 https://www.apache.org/licenses/LICENSE-2.0
  */

frontend/package.json

@@ -7,7 +7,7 @@
     "@testing-library/jest-dom": "^5.17.0",
     "@testing-library/react": "^13.4.0",
     "@testing-library/user-event": "^13.5.0",
-    "lightweight-charts": "^4.1.3",
+    "lightweight-charts": "^4.1.4",
     "react": "^18.2.0",
     "react-dom": "^18.2.0",
     "react-scripts": "^3.0.1",

frontend/src/components/chart_panel.jsx

@@ -129,16 +129,25 @@ const ChartPanel = ({ settings, id, setPanels }) => {
 
             charts[chart.id].applyOptions({
                 autoscaleInfoProvider: (original) => {
-                    const res = original();
-                    if (res !== null) {
-                        if (settings.minY != null) {
-                            res.priceRange.minValue = settings.minY;
+                    const scaleSettings = original();
+                    if (scaleSettings !== null) {
+                        let isLeftPriceScaleId = chart.settings.priceScaleId === "left";
+                        const minYValue = isLeftPriceScaleId
+                            ? (settings.leftMinY ?? settings.minY)
+                            : (settings.rightMinY ?? settings.minY);
+
+                        const maxYValue = isLeftPriceScaleId
+                            ? (settings.leftMaxY ?? settings.maxY)
+                            : (settings.rightMaxY ?? settings.maxY);
+
+                        if (minYValue !== null) {
+                            scaleSettings.priceRange.minValue = minYValue;
                         }
-                        if (settings.maxY != null) {
-                            res.priceRange.maxValue = settings.maxY;
+                        if (maxYValue !== null) {
+                            scaleSettings.priceRange.maxValue = maxYValue;
                         }
                     }
-                    return res;
+                    return scaleSettings;
                 },
             });
 

src/LightweightCharts.jl

@@ -128,7 +128,11 @@ mutable struct LWCPanel <: AbstractChartSettings
     y::Int64
     name::String
     min_y::Union{Real,Nothing}
+    left_min_y::Union{Real,Nothing}
+    right_min_y::Union{Real,Nothing}
     max_y::Union{Real,Nothing}
+    left_max_y::Union{Real,Nothing}
+    right_max_y::Union{Real,Nothing}
     seconds_visible::Bool
     bar_spacing::Real
     min_bar_spacing::Real
@@ -153,7 +157,11 @@ Creates a panel combining several [`charts`](@ref charts).
 | `y::Int64` | `-999` | Panel's vertical coordinates |
 | `name::String` |` "LightweightCharts ❤️ Julia"` | Panel name (will be displayed in the browser tab title). |
 | `min_y::Union{Real,Nothing}` | `nothing` | Lower bound on the y-axis. |
-| `max_y::Union{Real,Nothing}` | `nothing` | Lower bound on the y-axis. |
+| `left_min_y::Union{Real,Nothing}` | `nothing` | Lower bound on the left y-axis. |
+| `right_min_y::Union{Real,Nothing}` | `nothing` | Lower bound on the right y-axis. |
+| `max_y::Union{Real,Nothing}` | `nothing` | Upper bound on the y-axis. |
+| `left_max_y::Union{Real,Nothing}` | `nothing` | Upper bound on the left y-axis. |
+| `right_max_y::Union{Real,Nothing}` | `nothing` | Upper bound on the right y-axis. |
 | `seconds_visible::Bool` | `false` | Seconds visibility on the x-axis. |
 | `bar_spacing::Real` | `6` | Distance between the stripes in pixels. |
 | `min_bar_spacing::Real` | `0.5` | Minimum distance between the stripes in pixels. |
@@ -166,7 +174,11 @@ function lwc_panel(
     y::Int64 = -999,
     name::String = "LightweightCharts ❤️ Julia",
     min_y::Union{Real,Nothing} = nothing,
+    left_min_y::Union{Real,Nothing} = nothing,
+    right_min_y::Union{Real,Nothing} = nothing,
     max_y::Union{Real,Nothing} = nothing,
+    left_max_y::Union{Real,Nothing} = nothing,
+    right_max_y::Union{Real,Nothing} = nothing,
     seconds_visible::Bool = false,
     bar_spacing::Real = 6,
     min_bar_spacing::Real = 0.5,
@@ -178,7 +190,11 @@ function lwc_panel(
         y,
         name,
         min_y,
+        left_min_y,
+        right_min_y,
         max_y,
+        left_max_y,
+        right_max_y,
         seconds_visible,
         bar_spacing,
         min_bar_spacing,