-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump to 24.1 - Single-container setup #607
base: master
Are you sure you want to change the base?
Conversation
Very cool, I triggered a test run. It would be nice if we can get tests to turn green at some point. But they probably also need to be updated. Thanks a lot! |
As a first step feel free to concentrate on the single-container option. Then the PR are easier to review. |
The single-container changes are done, and I’ve also updated the compose files. Everything seems to be working well, and all tests in the forked repo have passed. I also updated the tool versions for the workflow tests, as the old ones seemed incompatible. Next, I’ll work on adding the Rustus service, integrating interactive tools, and replacing Nginx with Traefik in the compose setup. Let me know if you have any feedback on the current changes. Thanks! |
@jyotipm29 really impressive work. Thanks you a lot. |
This looks really cool @jyotipm29 Thanks a lot! 🚀
A bit more important than the compose setup and traefik would be to successively replace ansible-galaxy-extras with the roles that are maintained and e.g. used in usegalaxy-eu/infrastructure-playbook or on the org server. Sorry that we did not came up with this earlier and you already updated the role in your fork. Maybe it makes the replacement easier, because you can replace the roles one by one and run the ci tests in between. |
Thanks! I will check that out. |
Sure! Björn already left his comments and suggestions, and I thought Jyoti would probably want to address them. However, as you pointed out, this can be merged. @jyotipm29 Excellent work! Thank you! :) |
@jyotipm29 what do you think about postponing the CI compose tests until after the single-container tests is green. This way we safe a bit of CI time and you can faster iterate on the single-container one? |
Yes, good idea. I would temporarily disable those tests in the next commit. |
If someone wants to test it quickly :)
|
I get ...
So installing tools into the container does not work with the container. Its strange, I thought we had a test for this. |
This is weird. The tool installation worked in my environment. |
Did you run with or without --privileged=true? |
It worked both ways. Even I can see in the CI test logs that the tool installation worked. |
Which tool.are you using to install? |
I tested cherry_pick_fasta and abyss. Is there any particular tool that you want me to check? |
Just to confirm, the idea is to completely phase out ansible-galaxy-extras and instead use individual roles like usegalaxy_eu.nginx, usegalaxy_eu.htcondor etc, similar to how we currently use galaxyproject.postgresql in this repository. Is this correct? |
Yes :-). And now since the tests work I would do that one commit at a time and see if tests still work. |
While installing cvmfs client from ansible-cvmfs role during docker build, it requires autofs to be running, and autofs can't run without privileged mode. Do you have any suggestions for this? |
Maybe this might help: https://github.com/cvmfs/cvmfsexec |
See #609 for a few more information. |
Upgrades:
Updates:
New Service Support:
/rabbitmq/
path. The default access credentials areadmin:admin
./flower/
path. The default access credentials areadmin:admin
.Ansible Playbooks:
guest
user and addsadmin
,galaxy
, andflower
users for RabbitMQ during container startup.Environment Variables:
GUNICORN_WORKERS
andCELERY_WORKERS
magic environment variables to set the number of Gunicorn and Celery workers, respectively, during container startup.Configuration Changes:
/etc/galaxy/gravity.yml
.tools_conf_interactive.xml.sample
is placed insideGALAXY_CONFIG_DIR
. Nginx is also configured to support both domain and path-based ITs.cvmfs-config.galaxyproject.org
repository for automatic configuration and updates of Galaxy project CVMFS repositories. Updated tool data table config path to include CVMFS locations fromdata.galaxyproject.org
in--privileged
mode.docker_net
,docker_auto_rm
, anddocker_set_user
parameters for Docker-enabled job destinations.update_yaml_value.py
script to update nested key values in a YAML file.ie_proxy
withgx-it-proxy
.nginx_upload_module
withTUSd
for delegated uploads.