Fixes #16480: Prevent exponential denormalization on Transform::rotate_axis
#17604
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
| @@ -314,7 +314,7 @@ impl Transform { | |||
| /// If this [`Transform`] has a parent, the `axis` is relative to the rotation of the parent. | |||
| #[inline] | |||
| pub fn rotate_axis(&mut self, axis: Dir3, angle: f32) { | |||
| self.rotate(Quat::from_axis_angle(axis.into(), angle)); | |||
| self.rotation = ((Quat::from_axis_angle(axis.into(), angle)) * self.rotation).normalize(); | |||
There was a problem hiding this comment.
Link the issue here in a comment please; this normalization looks out of place otherwise.
There was a problem hiding this comment.
Done! Is it fine like this or should I add the full link?
Novakasa
force-pushed
the
rotate-axis-normalize
branch
from
0f2a51d to
a4a1078
Compare
aloucks
reviewed
Jan 29, 2025
…form::rotate_axis`
Novakasa
force-pushed
the
rotate-axis-normalize
branch
from
a4a1078 to
e23fe5f
Compare
alice-i-cecile
approved these changes
Jan 29, 2025
alice-i-cecile
added
C-Bug
Carter0
approved these changes
Jan 30, 2025
alice-i-cecile
added
the
X-Contentious
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #16480
When repeatedly using
Transform::roatate_axisand feeding aaxisthat is based on the currentTransform::rotation, the floating point errors could accumulate exponentially, resulting in denormalized rotation, which panics.Solution
Normalize the quaternion in
Transform::rotate_axis.Testing
I confirmed that this fixes the issue reported in #16480.