Remove unnecessary PartialReflect
bound on DeserializeWithRegistry
#17560
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
The new
DeserializeWithRegistry
trait in 0.15 was designed to be used with reflection, and so has atrait DeserializeWithRegistry: PartialReflect
bound. However, this bound is not actually necessary for the trait to function properly. And thisPartialReflect
bound already exists on:So there is no point in constraining the trait itself with this bound as well.
This lets me use
DeserializeWithRegistry
with non-Reflect
types, which I want to do to avoid making a bunch ofFooDeserializer
structs andimpl DeserializeSeed
on them.Solution
Removes this unnecessary bound.
Testing
Trivial change, does not break compilation or
bevy_reflect
tests.Migration Guide
DeserializeWithRegistry
types are no longer guaranteed to bePartialReflect
as well. If you were relying on this type bound, you should add it to your own bounds manually.