Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no-camera many_buttons argument, only emit UI camera warnings once #17557

Merged
merged 3 commits into from
Jan 28, 2025
Merged

no-camera many_buttons argument, only emit UI camera warnings once #17557

merged 3 commits into from
Jan 28, 2025

Conversation

ickshonpe
Copy link
Contributor

Objective

  • Add a no-camera argument to the many_buttons stress test example.
  • Only emit the UI "no camera found" warnings once.

@ickshonpe
* Added a no-camera argument to the many_buttons stress text exam…
5b16960 
…ple. No camera is spawned with it enabled.

* Only emit the "No camera found" warnings" once.

* Set the corresponding taffy nodes to UI nodes without a camera to `Display::None` instead of just default.
@ickshonpe
replace changes
b52aba3
@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-UI Graphical user interfaces, styles, layouts, and widgets S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it C-Benchmarks Stress tests and benchmarks used to measure how fast things are D-Trivial Nice and easy! A great choice to get started with Bevy labels Jan 27, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jan 28, 2025
Merged via the queue into bevyengine:main with commit a80263a Jan 28, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-UI Graphical user interfaces, styles, layouts, and widgets C-Benchmarks Stress tests and benchmarks used to measure how fast things are C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ickshonpe @alice-i-cecile