Skip to content

Commit

Permalink
setup-util: figured it out
Browse files Browse the repository at this point in the history
the reason installers were being dumped to stdout on ci, but not locally, was because the CI flow did not have the outputpipe defined

/ref https://github.com/bevry/dorothy/actions/runs/12899163098/job/35967485118#step:2:305
  • Loading branch information
balupton committed Jan 22, 2025
1 parent 2c09a07 commit a294247
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions commands/setup-util
Original file line number Diff line number Diff line change
Expand Up @@ -3452,11 +3452,7 @@ function setup_util() (
# action
for script in "${scripts[@]}"; do
# this should always be a function, otherwise use INSTALLER
if is-ci; then
"$script" --quiet="$option_quiet" >"$terminal_device_file"
else
"$script" --quiet="$option_quiet"
fi
"$script" --quiet="$option_quiet" >"$terminal_device_file"
done
}

Expand Down Expand Up @@ -3812,7 +3808,7 @@ function setup_util() (
eval_capture --statusvar=run_status --outputvar=run_output --outputpipe="$terminal_device_file" -- "$fn"
__print_string "$default_screen_buffer" >"$terminal_device_file"
else
eval_capture --statusvar=run_status -- "$fn"
eval_capture --statusvar=run_status --outputpipe="$terminal_device_file" -- "$fn"
fi

if [[ $run_status -eq 0 ]]; then
Expand Down

0 comments on commit a294247

Please sign in to comment.