-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration de la documentation technique #2711
Merged
Merged
Changes from 19 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
695a16c
move specs and test action
jonathanfallon 294e286
ci
jonathanfallon 5e9571f
ci
jonathanfallon 51c41d0
ci
jonathanfallon 534619a
ci
jonathanfallon 87b83ec
ci
jonathanfallon 92a8429
ci
jonathanfallon f54cdf3
ci
jonathanfallon 03c9e5d
ci
jonathanfallon c556d37
ci
jonathanfallon 6487f91
ci
jonathanfallon 97848cf
activate
jonathanfallon 5d32f18
add PR template
jonathanfallon 0aaef51
merge openapi v3.1 files
jonathanfallon 3ba40e0
test deploy on working branch
jonathanfallon ab06888
validate swagger
jonathanfallon bca7538
ci
jonathanfallon 80af8b2
proofread API v3.1 spec
jonathanfallon a2769dd
set deployment to releases only in github action
jonathanfallon 1bc8d34
try-out x-topic
jonathanfallon c19f2d2
ci
jonathanfallon 9863dfc
ci
jonathanfallon 3de84e3
ci
jonathanfallon d9389ec
ci
jonathanfallon 824bb12
ci
jonathanfallon 43b782b
ci
jonathanfallon 61a326a
ci
jonathanfallon ddc76e8
ci
jonathanfallon 990b71b
Merge branch 'main' into chore/add-bump-action
jonathanfallon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
#fixes (issues) | ||
|
||
## Description | ||
|
||
<!-- compléter ici --> | ||
|
||
## Checklist | ||
|
||
- [ ] [j'ai suivi les guidelines du "clean code"](https://gist.github.com/wojteklu/73c6914cc446146b8b533c0988cf8d29) | ||
- [ ] [j'ai mis à jour la documentation technique](https://www.notion.so/Documentation-technique-du-Registre-de-preuve-de-covoiturage-14b994bec93180f98a89da28aff88f32) | ||
- [ ] ajout ou mise à jour des tests unitaires | ||
- [ ] ajout ou mise à jour des tests d'intégration | ||
|
||
## Merge | ||
|
||
Je squash la PR et vérifie que le message de commit utilise | ||
[la convention d'Angular](https://github.com/angular/angular/blob/main/CONTRIBUTING.md#-commit-message-format) : | ||
|
||
``` | ||
<type>(<scope>): <short summary> | ||
│ │ │ | ||
│ │ └─⫸ Summary in present tense. Not capitalized. No period at the end. | ||
│ │ | ||
│ └─⫸ Commit Scope: proxy|acquisition|export|... | ||
│ | ||
└─⫸ Commit Type: build|ci|docs|feat|fix|perf|refactor|test | ||
``` | ||
Types de commit | ||
|
||
- build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm) | ||
- ci: Changes to our CI configuration files and scripts (examples: Github Actions) | ||
- docs: Documentation only changes | ||
- feat: A new feature (Minor bump) | ||
- fix: A bug fix (Patch bump) | ||
- perf: A code change that improves performance | ||
- refactor: A code change that neither fixes a bug nor adds a feature | ||
- test: Adding missing tests or correcting existing tests | ||
|
||
Le _scope_ (optionnel) précise le module ou le composant impacté par le commit. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
name: Deploy API documentation | ||
permissions: | ||
contents: read | ||
on: | ||
workflow_dispatch: | ||
release: | ||
types: [published] | ||
jobs: | ||
deploy-doc: | ||
name: Deploy | ||
runs-on: ubuntu-latest | ||
|
||
# add files here | ||
strategy: | ||
matrix: | ||
include: | ||
- doc: api | ||
version: v3.1 | ||
token: BUMP_TOKEN_API | ||
- doc: api | ||
version: v3.0 | ||
token: BUMP_TOKEN_API | ||
|
||
steps: | ||
- name: Checkout | ||
uses: actions/checkout@v4 | ||
|
||
- name: Verify OpenAPI files | ||
run: | | ||
file="api/specs/${{ matrix.doc }}-${{ matrix.version }}.yaml" | ||
if [ ! -f "$file" ]; then | ||
echo "Error: $file does not exist" | ||
exit 1 | ||
fi | ||
|
||
- name: Validate OpenAPI syntax | ||
uses: swaggerexpert/swagger-editor-validate@v1 | ||
with: | ||
definition-file: api/specs/${{ matrix.doc }}-${{ matrix.version }}.yaml | ||
|
||
- name: Deploy | ||
uses: bump-sh/github-action@v1 | ||
with: | ||
doc: ${{ matrix.doc }} | ||
token: ${{ secrets[matrix.token] }} | ||
file: api/specs/${{ matrix.doc }}-${{ matrix.version }}.yaml | ||
jonathanfallon marked this conversation as resolved.
Show resolved
Hide resolved
|
||
branch: ${{ matrix.version }} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Add missing workflow triggers
The workflow is only triggered by
workflow_dispatch
andrelease
events. Consider adding:push
events for automated deployments when documentation changespull_request
events for validation on PRs📝 Committable suggestion