chore(build): migrate to nx@17 and remove lerna (#2317)

* migrate to nx@17 and remove lerna * update actions * fix * clean up * clean up
betagouv · Nov 9, 2023 · e765992 · e765992
1 parent 89a334b
commit e765992
Show file tree

Hide file tree

Showing 12 changed files with 3,703 additions and 9,320 deletions.
diff --git a/.github/workflows/analysis.yml b/.github/workflows/analysis.yml
@@ -13,10 +13,10 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout code
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Install NodeJS
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
           node-version: '20'
 
@@ -41,10 +41,10 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout code
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Install NodeJS
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
           node-version: '20'
 
@@ -66,10 +66,18 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout code
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
+
+      - name: Nx Cache
+        id: nx-cache
+        uses: actions/cache@v3
+        with:
+          path: api/.nx/cache
+          key: ${{ runner.os }}-nx-cache
+          restore-keys: ${{ runner.os }}-nx-cache
 
       - name: Install NodeJS
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
           node-version: '20'
           cache: 'npm'
@@ -81,14 +89,10 @@ jobs:
 
       - name: Build
         run: npm run build
-        env:
-          NX_CLOUD_ACCESS_TOKEN: ${{ secrets.NX_CLOUD_ACCESS_TOKEN }}
         working-directory: api
 
       - name: Run Unit test
         run: npm run test:unit
-        env:
-          NX_CLOUD_ACCESS_TOKEN: ${{ secrets.NX_CLOUD_ACCESS_TOKEN }}
         working-directory: api
 
   codeql:
@@ -102,7 +106,7 @@ jobs:
 
     steps:
     - name: Checkout repository
-      uses: actions/checkout@v3
+      uses: actions/checkout@v4
       with:
         fetch-depth: 2
 
@@ -123,10 +127,18 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout code
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
+
+      - name: Nx Cache
+        id: nx-cache
+        uses: actions/cache@v3
+        with:
+          path: api/.nx/cache
+          key: ${{ runner.os }}-nx-cache
+          restore-keys: ${{ runner.os }}-nx-cache
 
       - name: Install NodeJS
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
           node-version: '20'
           cache: 'npm'
@@ -138,8 +150,6 @@ jobs:
 
       - name: Build
         run: npm run build
-        env:
-          NX_CLOUD_ACCESS_TOKEN: ${{ secrets.NX_CLOUD_ACCESS_TOKEN }}
         working-directory: api
 
       - name: Add host entries
@@ -174,5 +184,4 @@ jobs:
           APP_SESSION_SECRET: null
           APP_ROUTECACHE_AUTHTOKEN: null
           AWS_REGION: fr-par
-          NX_CLOUD_ACCESS_TOKEN: ${{ secrets.NX_CLOUD_ACCESS_TOKEN }}
         run: ./integration.sh run
diff --git a/.github/workflows/base-deploy-to-bucket.yml b/.github/workflows/base-deploy-to-bucket.yml
@@ -36,12 +36,12 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout 🛎️
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           persist-credentials: false
 
       - name: Install NodeJS
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
           node-version: '20'
           cache: 'npm'

diff --git a/.github/workflows/deploy-backends.yml b/.github/workflows/deploy-backends.yml
@@ -23,7 +23,14 @@ jobs:
           - { name: 'datatools', dockerfile: './docker/notebook/Dockerfile' }
     steps:
       - name: Checkout code
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
+      - name: Nx Cache
+        id: nx-cache
+        uses: actions/cache@v3
+        with:
+          path: api/.nx/cache
+          key: ${{ runner.os }}-nx-cache
+          restore-keys: ${{ runner.os }}-nx-cache
       - name: Set up QEMU
         uses: docker/setup-qemu-action@v2
       - name: Set up Docker Buildx
@@ -46,8 +53,6 @@ jobs:
           load: true
           push: false
           tags: betagouvpdc/${{ matrix.image.name }}:${{ env.tag }}
-          build-args: |
-            DOCKER_NX_CLOUD_ACCESS_TOKEN=${{ secrets.NX_CLOUD_ACCESS_TOKEN }}
           labels: |
             org.opencontainers.image.title=${{ matrix.image.name }} Image
             org.opencontainers.image.source=${{ github.event.repository.html_url }}
@@ -82,8 +87,6 @@ jobs:
           file: ${{ matrix.image.dockerfile }}
           push: true
           tags: betagouvpdc/${{ matrix.image.name }}:${{ env.tag }}
-          build-args: |
-            DOCKER_NX_CLOUD_ACCESS_TOKEN=${{ secrets.NX_CLOUD_ACCESS_TOKEN }}
           labels: |
             org.opencontainers.image.title=${{ matrix.image.name }} Image
             org.opencontainers.image.source=${{ github.event.repository.html_url }}

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -10,7 +10,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
       - name: Semantic Release
         uses: cycjimmy/semantic-release-action@v3
         with:

diff --git a/api/.gitignore b/api/.gitignore
@@ -5,3 +5,4 @@ dist
 .env
 coverage
 .nyc_output
+.nx/cache
diff --git a/api/lerna.json b/api/lerna.json
diff --git a/api/nx.json b/api/nx.json
@@ -1,15 +1,19 @@
 {
-  "$schema": "node_modules/nx/schemas/nx-schema.json",
-  "tasksRunnerOptions": {
-    "default": {
-      "runner": "@nrwl/nx-cloud",
-      "options": {
-        "cacheableOperations": [
-          "build",
-          "test:unit"
-        ]
-      }
+  "extends": "nx/presets/npm.json",
+  "targetDefaults": {
+    "build": {
+      "cache": true,
+      "dependsOn": ["^build"]
+    },
+    "test:unit": {
+      "cache": true
+    },
+    "coverage": {
+      "cache": true
     }
   },
-  "defaultBase": "main"
+  "affected": {
+    "defaultBase": "main"
+  },
+  "parallel": 16
 }