-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: posthog informations transmition + data package refactos #1546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Première passe après échange avec @ttdm en début de journée, review de la refacto archi data et passe fonctionnelle sur l'app (server dev et build OK). |
dolemoine
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/!\ A ne pas merge, à review sans merge ! (350lignes à review,le reste c'est de la data)
Partie 1 de la PR : posthog
Je pense que c'est une PR intéressante à discuter avant review ou à review en pair.
L'idée est de créer des events posthogs liés aux envois de formulaires.
Les events posthogs étant non supprimable, la PR renvoie pour l'instant des console.log().
L'idée est de valider ces consoles.log() ensemble puis d'éxcuter une fois la PR "pour de vrai".
Cela permettra de créer une première série d'events.
Il faudra ensuite repasser en logs, pour vérifier qu'il n'y a pas de création d'events en doublon.
Une fois cela au point, on pourra valider la PR pour un passage en prod.
Remarques :
import posthog, { PostHog } from 'posthog-js'
; il a fallu que je modifie cet import enimport { posthog, PostHog } from 'posthog-js'
. Le premier code, non fonctionnel ici, est pourtant présent dans le front. étonnant ?Partie 2 de la PR : le refacto du package data :
close #1244
close #901