Feat/siret project catalog impact nuxt #1467
Open
+797
−528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced a new company data filter to improve the customization of program listings based on selected company attributes. The filter integration enables toggling visibility and selection of programs through company-specific criteria, enhancing user navigation and interaction within the program catalog. Modifications include updates to related components, data handling, and eligibility checks to align with the new filter functionality.
Updated ProgramFiltersAccordion component to enhance filter visibility control by replacing `shouldDisplayFilter` with `canDisplayFilter` and introducing `companyDataFilterVisibilityClass`. This change ensures proper class assignment based on company's data presence, improving clarity and maintainability of the filter logic. Adjusted active accordion index initialization for better UI responsiveness.
This commit introduces a newline to enhance code readability and maintain formatting consistency. While it may seem minor, such adjustments contribute to better organized code and ease of future maintenance.
Replaced hardcoded filter keys with `FilterItemKeys` enum for consistency and maintainability. Updated related components, stores, and utility functions to adopt the new structure. This simplifies key management and improves code readability.
Replaced hardcoded timeouts with a shared `timeOut` constant to enhance maintainability in e2e tests. Simplified logic in `usedTrack.ts` for clarity and updated Playwright reporter configuration for better control on CI systems.
… logic. Moved the company filter configuration into a standalone constant and adjusted its rendering logic. This enhances code clarity and maintainability by isolating the company filter from other filters in the accordion.
Replaced the `companyDataAccordion` ref with a primitive `number` value since reactivity was not required. Simplifies the code and avoids unnecessary overhead.
Updated filter to include conditional grey background and text for inactive state. Improved layout with grid rows for better alignment and spacing. This enhances the component's visual hierarchy and accessibility.
Introduce the `resetFilter` method to reset specific filters in the program store. Updated the `ProgramFilter` logic to utilize `resetFilter` for improved filter management consistency. Minor import adjustments were also made for better organization.
Introduced a mapping object to convert StructureSize enums to user-friendly text labels. Updated the company size filter to display these labels, improving clarity and usability of the company data filtering component.
# Conflicts: # apps/web-e2e/src/config.ts # apps/web-e2e/src/programResults.spec.ts # apps/web-e2e/src/projectResults.spec.ts # apps/web/src/components/identification/TeeRegisterModal.vue
Replaced all instances of `CompanyDataStorage` with `CompanyData` for streamlined and consistent company data access. Updated methods and references accordingly to enhance maintainability and readability across components.
Replaced `CompanyDataStorage` with `CompanyData` for improved consistency and modernized data handling. Adjusted related method calls and imports, ensuring better alignment with current code practices and reducing redundancy. Updated UI logic to reflect changes in navigation store behavior.
Updated the icon span with a new class for padding and adjusted its pseudo-element styling to improve alignment and consistency. Ensures better visual presentation across the component.
Reinstates the link for the "NotEligible" program state, redirecting users to the catalog of eligible programs. This provides a clearer path for users to explore relevant assistance options.
Renamed the `programFiltersType` type to `ProgramFiltersType` across the codebase for consistency with PascalCase naming conventions. This improves code readability and aligns with type naming standards in the project.
# Conflicts: # apps/nuxt/src/tools/companyData/companyDataSchemaValidator.ts # apps/nuxt/src/tools/companyData/types/companyDataType.ts # libs/backend-ddd/src/program/infrastructure/preprocessProgramsPublicodes.ts # libs/backend-ddd/src/project/domain/projectFeatures.ts # libs/common/src/establishment/naf1.ts # libs/common/src/establishment/types.ts
…panyData` Remove `null` as a possible value for the `title` prop, ensuring stricter type-checking. This update improves type safety and aligns with expected usage.
Reorganized and renamed filter components for better modularity. Introduced a reusable `ModalFilter` component and updated corresponding references. Simplified and standardized filter logic across programs and projects.
ttdm
requested changes
Jan 22, 2025
apps/nuxt/src/stores/filters.ts
Outdated
There was a problem hiding this comment.
Petite réflexion d'archi globale mais j'ai ll'impression que serait bien de clarifier en réu dev ce qu'on veut traiter comme du filtre front vs de la responsabilité du back.
J'ai l'impression qu'on avait la volonté de passer pas mal de choses dans le back et qu'au final on a tout repassé dans le front.
Après c'est très clean !
There was a problem hiding this comment.
partant pour échanger sur le sujet sur un point tech
|
Message général associé à la review : Praise, gros travail de refacto ! Suggestion d'amélioration :
|
Added `<script setup lang="ts"></script>` blocks to ensure proper TypeScript handling in `ProjectModalFilter.vue` and `ProgramModalFilter.vue`. This update improves consistency and follows best practices for script usage in Vue 3 components.
Comme discuté ce matin, ce point est vu avec Coline et une amélioration sera embarquée prochainement |
dolemoine
requested review from
yvalentin
and removed request for
oumeimaelisbihani
Introduced `ProjectEligibility` class to centralize the eligibility check, replacing inline filtering logic across the codebase. This improves code maintainability and promotes consistency in project queries. Removed redundant `onNuxtReady` call in `CatalogProjects.vue` for optimization.
# Conflicts: # apps/nuxt/src/components/catalog/CatalogPrograms.vue # apps/nuxt/src/components/catalog/CatalogProjects.vue # apps/nuxt/src/middleware/resetFilters.ts
…ove reusability after home page refacto Introduced `SimpleProjectList`, `TeeHomeProjectList`, and `CatalogBanner` components to enhance modularity and reusability. Updated existing components to use these new modular elements, simplifying logic and reducing duplication across the codebase.
|
Note : cette PR embarque également un peu de refacto suite à la refonte de la home page. c'est un point d'attention à avoir lors de la review @yvalentin |
…ect Catalog Move `hasFullRegisteredData` to a reactive `ref` and initialize it within `onNuxtReady`. Simplify template class binding for improved readability and maintainability.
The .project-cards-container style is moved from CatalogProjects.vue to SimpleProjectList.vue for better component structure.
Replaced `projectList` with `sortedProjects` for better clarity and removed redundant computed logic in `CatalogProjects.vue`. Updated layout in `CatalogLayout.vue` to improve error handling, spinner logic, and title rendering. These changes enhance maintainability and UI consistency.
…t-nuxt' into feat/siret-project-catalog-impact-nuxt # Conflicts: # apps/nuxt/src/components/catalog/CatalogProjects.vue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ajout du filtrage sur le catalogue projet et refactorisation filtres et composants liées
Améliorations de l'interface utilisateur et des composants :
apps/nuxt/src/components/catalog/CatalogLayout.vue: Ajout d'un nouveau composantCatalogLayoutpour standardiser la mise en page des catalogue.apps/nuxt/src/components/catalog/CatalogPrograms.vue,apps/nuxt/src/components/catalog/CatalogProjects.vue: Refactorisation de ces composants pour utiliser le nouveau composantCatalogLayout.Modifications de la gestion des filtres
apps/nuxt/src/stores/filters.ts: Ajout d'un nouveau store pour gérer globalement les filtres catalogues et pages deapps/nuxt/src/stores/program.tsetapps/nuxt/src/stores/project.ts: Suppression des filtres spécifiques à chaque store au profit des filtres générique sur storeapps/nuxt/src/stores/filters.ts.apps/nuxt/src/stores/filters.tsModifications supplémentaires :
apps/nuxt/src/components/filters/FiltersAccordion.vue: Ajout d'un nouveau composantFiltersAccordionpour gérer la logique d'affichage des filtres et améliorer l'expérience utilisateur. LesProgramFiltersAccordion.vueetProjectFiltersAccordiondépendent de ce nouveauFiltersAccordion.vue.apps/nuxt/src/components/filters/ModalFilter.vue: refactorisation duProgramModalFilter.vuepour le rendre générique et utilisable sur les pages programmes et projet.apps/nuxt/src/components/identification/TeeRegisterModal.vue: Mise à jour de la modal d'inscription pour réinitialiser les états des filtres lors de la réinitialisation du SIRET.Related issues:
close #1431
close #1433