Utilisation de la Gem dsfr-assets pour le guide #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freesteph
reviewed
Jan 23, 2025
| gem 'nanoc-live' | ||
| gem 'sass-embedded' |
There was a problem hiding this comment.
pourquoi il faut sass-embedded? c'est du pure CSS non ?
There was a problem hiding this comment.
Aujourd’hui c’est du scss et on avait le package sass
Après on peut se poser la question de l’intérêt d’utiliser du scss ici
Dans tous les cas, j'ai laissé en draft parce qu’il y a des éléments du DSFR qui n’existent pas dans dsfr-assets donc il y a encore des petites choses à solutionner
freesteph
reviewed
Jan 23, 2025
| // Import the DSFR | ||
| @import "dsfr/dist/dsfr.min"; | ||
| @import "dsfr/dist/utility/utility.min"; | ||
| @use "dsfr.min"; |
freesteph
reviewed
Jan 23, 2025
|
|
||
| o | ||
| Nanoc::Filter.define(:dart_sass) do |_, opts| | ||
| Sass.compile(opts[:target], style: :compressed).css |
There was a problem hiding this comment.
my bad mais du coup le require d'en haut m'interpelle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintenant que nous avons une Gem dsfr-assets, il peut être intéressant de l’utiliser plutôt que d’utiliser le package npm.