Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix student search #1331

Merged
merged 10 commits into from
Jan 15, 2025
Merged

Fix student search #1331

merged 10 commits into from
Jan 15, 2025

Conversation

pskl
Copy link
Collaborator

@pskl pskl commented Jan 14, 2025 •
edited
Loading

  • use distinct instead of uniq
  • use regex
  • simplify query

@pskl pskl force-pushed the hotfix/fix-search branch from 43458f1 to 9975267 Compare January 15, 2025 11:45
@pskl pskl force-pushed the hotfix/fix-search branch from 9975267 to 4e582b3 Compare January 15, 2025 12:12
@pskl pskl requested a review from tnicolas1 January 15, 2025 12:13
tnicolas1
tnicolas1 requested changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@tnicolas1 tnicolas1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il faudrait gérer le cas des noms avec des apostrophes
EX: Rechercher ndiaye pour N'Diaye

@pskl pskl requested a review from tnicolas1 January 15, 2025 14:42
@pskl pskl merged commit edcbae0 into main Jan 15, 2025
5 checks passed
@pskl pskl deleted the hotfix/fix-search branch January 15, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnicolas1 tnicolas1 tnicolas1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pskl @tnicolas1