Skip to content

Commit

Permalink
Bump to 2.0.8 (#1296)
Browse files Browse the repository at this point in the history
  • Loading branch information
pskl authored Dec 18, 2024
1 parent d4b9080 commit 7aee82d
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 5 deletions.
2 changes: 1 addition & 1 deletion app/models/pfmp.rb
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ def rectify!
end

def rectified?
in_state?(:rectified?)
in_state?(:rectified)
end

def relative_index
Expand Down
2 changes: 1 addition & 1 deletion config/initializers/version.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# frozen_string_literal: true

module Aplypro
VERSION = "2.0.7"
VERSION = "2.0.8"
end
4 changes: 1 addition & 3 deletions lib/asp/entities/adresse.rb
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,7 @@ def fragment(xml)
end

def self.from_payment_request(payment_request) # rubocop:disable Metrics/AbcSize,Metrics/MethodLength
# TODO: what about the case of a rectified pfmp for a student abroad
# what should be sent for cpltdistribution & pointremise
if payment_request.pfmp.in_state?(:rectified)
if payment_request.pfmp.rectified?
return new(
pointremise: payment_request.student.address_line1.slice(0, 38), # Max 38 characters
cpltdistribution: payment_request.student.address_line2&.slice(0, 38), # Max 38 characters
Expand Down

0 comments on commit 7aee82d

Please sign in to comment.