Fix attr for indu (#1348)

betagouv · Jan 22, 2025 · 5d425c0 · 5d425c0
1 parent 5d7574f
commit 5d425c0
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 9 deletions.
diff --git a/app/services/asp/mappers/adresse/indu_mapper.rb b/app/services/asp/mappers/adresse/indu_mapper.rb
@@ -4,14 +4,12 @@ module ASP
   module Mappers
     module Adresse
       class InduMapper < FranceMapper
-        # Max 38 characters
         def pointremise
-          student.address_line1.slice(0, 38)
+          student.address_line1
         end
 
-        # Max 38 characters
         def cpltdistribution
-          student.address_line2&.slice(0, 38)
+          student.address_line2
         end
       end
     end

diff --git a/lib/asp/entities/adresse/indu.rb b/lib/asp/entities/adresse/indu.rb
@@ -4,16 +4,17 @@ module ASP
   module Entities
     module Adresse
       class Indu < Entity
-        attribute :pointremise, :string
-        attribute :cpltdistribution, :string
+        ADRESSE_ATTR_MAX_LENGTH = 38
+
+        attribute :pointremise, :string, limit: ADRESSE_ATTR_MAX_LENGTH
+        attribute :cpltdistribution, :string, limit: ADRESSE_ATTR_MAX_LENGTH
         attribute :codetypeadr, :string
         attribute :codecominsee, :string
         attribute :codeinseepays, :string
         attribute :codepostalcedex, :string
 
         validates_presence_of %i[
           pointremise
-          cpltdistribution
           codetypeadr
           codeinseepays
           codepostalcedex

diff --git a/spec/lib/asp/entities/adresse/indu_spec.rb b/spec/lib/asp/entities/adresse/indu_spec.rb
@@ -15,8 +15,6 @@
 
     describe "validation" do
       it { is_expected.to validate_presence_of(:pointremise) }
-      it { is_expected.to validate_presence_of(:cpltdistribution) }
-
       it { is_expected.to validate_presence_of(:codepostalcedex) }
       it { is_expected.to validate_presence_of(:codecominsee) }
       it { is_expected.to validate_presence_of(:codeinseepays) }