Migration to Bootstrap 5 #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwaffen
previously approved these changes
Nov 8, 2023
Closed
Since Bs5 no longer depends on jQuery, and we do not use it anywhere else, this also removes that dependency. Some visual changes were unavoidable, but overall I took care not to change too much at once and existing users should feel right at home.
... as the dependency on jquery was removed.
With the old BS4 code, the primary color was applied automatically in this case. With the new accordion component in BS5 we need to add it explicitly.
|
Rebased and fixed one small regression that @tuxmea found. |
tuxmea
approved these changes
Dec 7, 2023
rwaffen
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #207
This replaces Bootstrap with the most recent version.
Since this a complete overhaul of the CSS framework, some visual changes were unavoidable, especially with the accordion component that has been completely rewritten from scratch. In other places I tried to mimick the old behavior as good as possible (without spending too much time on it). So overall I would say the difference is not too bad.
I also took the liberty to remove our dependency on jQuery, since bootstrap no longer requires it.