Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 'BasedOn' custom field option works with custom fields with autocomplete type #347

Open
wants to merge 1 commit into
base: stable
Choose a base branch
from

Conversation

danpoltawski
Copy link

@danpoltawski danpoltawski commented Jan 2, 2023

Previously this option didn't do anything when a custom field was based on an field which set to the autocomplete type.

Fixes https://rt.bestpractical.com/Ticket/Display.html?id=37524

There maybe more elaborate solutions to prevent this JS firing when the autocomplete is 'in progress', but I went for the minimal approach.

Testing instructions:

  • Make custom field 'Customer' with type 'Enter one value with autocompletion'
  • Set some values for the Customer ('Customer 1', 'Customer 2')
  • Make another Custom field 'Service' with type 'Select one value'
  • Set the Service custom field to be Based on 'Customer'
  • Add some values for the Service with the Category set to one of the customers, e.g.:

Screenshot 2023-01-02 at 11 55 45

* Ensure both custom fields are applied to a queue and observe the behaviour on the create ticket page

Before this patch:
'Service' was always set to 'Nothing Selected'

After this patch:
The correct values are chosen in the Selection dropdown
Screenshot 2023-01-02 at 11 59 00

Previously this option didn't do anything when a custom field was based
on an autocomplete type.

Fixes https://rt.bestpractical.com/Ticket/Display.html?id=37524
@danpoltawski danpoltawski changed the title 'BasedOn' custom field options now works with autocomplete type Make 'BasedOn' custom field option works with custom fields with autocomplete type Jan 2, 2023
@danpoltawski
Copy link
Author

Is RT a dead project?

@johnsonjh
Copy link

(A bit off-topic, and not related to the issue at hand, but …)

This month, excluding merges, 7 authors have pushed 77 commits to stable and 118 commits to all branches. On stable, 196 files have changed and there have been 5,580 additions and 670 deletions.

RT is is a highly active project …

@danpoltawski
Copy link
Author

A bit of a performative comment by me which I apologise for. But its a bit depressing to spend time on what seems like a simple fix, with clear testing instructions and have no feedback or even a comment to say we dont take contributions?

Then wondering whats been worked on and look RT bug tracker and see its full of spam thats been around for months:

image

I've got some more bugs to investigate and report and hopefully fix, but its difficult to motivate myself to look into them when seeing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants