Fix object comparison warning and bump version (#275)

bernii · Oct 23, 2024 · 11c063c · 11c063c
1 parent ca78d83
commit 11c063c
Show file tree

Hide file tree

Showing 7 changed files with 13 additions and 7 deletions.
diff --git a/dist/gauge.coffee b/dist/gauge.coffee
@@ -460,7 +460,7 @@ class Gauge extends BaseGauge
 		@ctx.restore()
 
 	renderTicks: (ticksOptions, w, h, radius) ->
-		if ticksOptions != {}
+		if typeof ticksOptions is 'object' and ticksOptions isnt null and Object.keys(ticksOptions).length > 0
 			divisionCount = ticksOptions.divisions || 0
 			subdivisionCount = ticksOptions.subDivisions || 0
 			divColor = ticksOptions.divColor || '#fff'

diff --git a/dist/gauge.js b/dist/gauge.js
diff --git a/dist/gauge.js.map b/dist/gauge.js.map
diff --git a/dist/gauge.min.js b/dist/gauge.min.js
diff --git a/index.html b/index.html
@@ -276,6 +276,12 @@ <h2>Supported browsers</h2>
 
 <h2>Changes</h2>
 
+<h3 id="v1.3.9">Version 1.3.9 (19.10.2024)</h3>
+<p>
+<ul>
+<li>Fixed <a href='https://github.com/bernii/gauge.js/issues/273'>#273</a> about inappropriate object comparison.</li>
+</ul>
+</p>
 <h3 id="v1.3.8">Version 1.3.8 (18.02.2024)</h3>
 <p>
 <ul>

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "gaugeJS",
-  "version": "1.3.8",
+  "version": "1.3.9",
   "description": "100% native and cool looking animated JavaScript/CoffeeScript gauge",
   "main": "dist/gauge.js",
   "repository": {