Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed imports to ESM #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

mhm13dev
Copy link

@mhm13dev mhm13dev commented Aug 7, 2022

No description provided.

@benwiley4000
Copy link
Owner

Thanks for the PR, however I'm not sure why it was needed. Could you please explain with some text instead of just opening a PR with no comment ? Otherwise it will be closed. Thanks for understanding.

@mhm13dev
Copy link
Author

mhm13dev commented Aug 7, 2022

Oh i thought you will be inactive on this repo. So I created a new repo and published an npm package.

Actually I was using it in a create-react-app and I was getting an error saying
ES Modules may not assign module.exports or exports

So I converted common js modules to esm in this package.

Let me know if I can create a new pull request with updated code from my repo.

@mhm13dev
Copy link
Author

mhm13dev commented Aug 7, 2022

By the way I updated this package and added some more props for my use case.

Here is the link:
https://www.npmjs.com/package/win95-media-player-esm

@benwiley4000
Copy link
Owner

I'm not sure I understand the context for create react app. What version are you using? Have you done any custom configuration? Normally webpack should support commonjs modules, although perhaps a new update removed this support?

@mhm13dev
Copy link
Author

mhm13dev commented Aug 7, 2022

I am using React 18.
I didn't add any custom config. I just installed it and it was throwing error. So I had to update

@mhm13dev
Copy link
Author

mhm13dev commented Aug 7, 2022

Don't merge this pull request.

I didn't mean to open this pull request. It was accidental.

I just cloned the repo and updated everything which I needed in that repo and published on npm.

This is the repo I worked in.
https://github.com/mhm13dev/win95-media-player-esm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants