fix: Remove distutils dependency #5179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frostming
approved these changes
Jan 10, 2025
aarnphm
reviewed
Jan 10, 2025
| @@ -8,7 +8,7 @@ | |||
| # add deadsnakes ppa to install python | |||
| add-apt-repository ppa:deadsnakes/ppa && \ | |||
| apt-get update -y && \ | |||
| apt-get install -y --no-install-recommends --allow-remove-essential {% if "ubuntu22.04" in __base_image__ and __options__python_version == "3.10" %}python{{ __options__python_version }}-jammy{% else %}python{{ __options__python_version }}{% endif %} python{{ __options__python_version }}-dev python{{ __options__python_version }}-distutils | |||
| apt-get install -y --no-install-recommends --allow-remove-essential {% if "ubuntu22.04" in __base_image__ and __options__python_version == "3.10" %}python{{ __options__python_version }}-jammy{% else %}python{{ __options__python_version }}{% endif %} python{{ __options__python_version }}-dev | |||
There was a problem hiding this comment.
wait shouldn't we negate check for other python version < 3.12?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR address?
python3.12-distutilsseems no longer available, see issue: #5178This PR removes the dependency.
Are there any automated test to validate all the python versions available?
Fixes #5178
Before submitting:
guide on how to create a pull request.
pre-commit run -ascript has passed (instructions)?those accordingly? Here are documentation guidelines and tips on writing docs.