Fix a fragment loadermanager bug that can lead to memory leaks

benoitletondor · Jul 15, 2016 · e0e0057 · e0e0057
1 parent 77dbdee
commit e0e0057
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/MVPBoilerplate/root/src/app_package/classes/BaseFragment.java.ftl b/MVPBoilerplate/root/src/app_package/classes/BaseFragment.java.ftl
@@ -48,8 +48,15 @@ public abstract class BaseFragment<P extends BasePresenter<V>, V> extends Fragme
         mUniqueLoaderIdentifier = savedInstanceState == null ? BaseActivity.sViewCounter.incrementAndGet() : savedInstanceState.getInt(LOADER_ID_SAVED_STATE);
 
         injectDependencies();
+    }
+
+    @Override
+    public void onActivityCreated(@Nullable Bundle savedInstanceState)
+    {
+        super.onActivityCreated(savedInstanceState);
 
-        getLoaderManager().initLoader(mUniqueLoaderIdentifier, null, this).startLoading();
+        // See http://stackoverflow.com/a/32289822/2508174 for the use of getActivity().getSupportLoaderManager()
+        getActivity().getSupportLoaderManager().initLoader(mUniqueLoaderIdentifier, null, this).startLoading();
     }
 
     private void injectDependencies()