Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Minor fixes #11

wants to merge 1 commit into from

Conversation

halkeye
Copy link
Contributor

@halkeye halkeye commented Jun 9, 2018

  • Update gitignore with stuff from gitignore.io
  • Update gitignore with compiled code
  • Add specific list of included files for npm (test with npx pkgfiles)

pkgfiles output:

PATH           SIZE     %   
gatsby-ssr.js  538 B    1%  
package.json   1.09 kB  2%  
index.js       2.57 kB  4%  
README.md      7.29 kB  10% 
yarn.lock      59.1 kB  84% 
                            
DIR            SIZE     %   
.              70.6 kB  100%

PKGFILES SUMMARY
Size on Disk with Dependencies  ~25.4 MB
Size with Dependencies          ~10.5 MB
Publishable Size                ~70.6 kB
Number of Directories           1       
Number of Files                 5       

* Update gitignore with stuff from gitignore.io
* Update gitignore with compiled code
* Add specific list of included files for npm (test with npx pkgfiles)
@benjaminhoffman
Copy link
Owner

open to the changes on package.json and .gitignore. thank you!

but shouldn't the change to index.js be included in #10 instead?

@halkeye
Copy link
Contributor Author

halkeye commented Jun 10, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants