-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove include(ctest)
#77
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can drop include(CTest)
entirely. Also, the code was simpler when FetchContent wasn't conditionally included.
Done in CMakeLists, the CI isn't failing so I guess this would work. Will this impact commands such as
Well, this is such a "when we are arguing we are losing" thing, just let me know if I should revert the change with |
Nope, we no longer need anything this module provides. |
Co-authored-by: David Sankel <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
ctest
and FetchContent
include(ctest)
Fixes #60 .
I am not really understanding if this is desired, so reject this if this change is not wanted.
Explicitly asking @camio @bretbrownjr and @ClausKlein for input.