Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove include(ctest) #77

Merged
merged 4 commits into from
Nov 14, 2024
Merged

Conversation

wusatosi
Copy link
Member

@wusatosi wusatosi commented Nov 14, 2024

Fixes #60 .

I am not really understanding if this is desired, so reject this if this change is not wanted.

Explicitly asking @camio @bretbrownjr and @ClausKlein for input.

Copy link
Member

@steve-downey steve-downey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@camio camio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can drop include(CTest) entirely. Also, the code was simpler when FetchContent wasn't conditionally included.

@wusatosi
Copy link
Member Author

wusatosi commented Nov 14, 2024

[we can drop include(CTest) entirely]

Done in CMakeLists, the CI isn't failing so I guess this would work.

Will this impact commands such as ctest --test-dir build --build-config Release?

The code was simpler when FetchContent wasn't conditionally included.

Well, this is such a "when we are arguing we are losing" thing, just let me know if I should revert the change with FetchContent.

CMakeLists.txt Outdated Show resolved Hide resolved
@camio
Copy link
Member

camio commented Nov 14, 2024

[we can drop include(CTest) entirely]

Will this impact commands such as ctest --test-dir build --build-config Release?

Nope, we no longer need anything this module provides.

Co-authored-by: David Sankel <[email protected]>
CMakeLists.txt Outdated Show resolved Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@wusatosi wusatosi changed the title Conditional include of ctest and FetchContent Remove include(ctest) Nov 14, 2024
@wusatosi wusatosi merged commit 241ba3e into bemanproject:main Nov 14, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do only include(CTest) if dashboard is needed
3 participants