Implement Use CMake Header File Sets #30

wusatosi · 2024-09-24T20:16:59Z

This PR closes #21 .

Uses FILE_SET feature instead the current include_directories.
Enables VERIFY_INTERFACE_HEADER_SETS (bumping cmake version note in Dockerfile and run all_verify_interface_header_sets on builds).

Please note that I am not familiar with cmake, so please double check my work.

Questions:

There's problem with FILE_PATTERN when matching the header file, is there a way to ask the FILE_PATTERN to search for the header file in a specific directory?
Is there a way I can avoid using the INCLUDE_DIR variable?
Do we need to mention this in README?

wusatosi · 2024-09-24T20:19:02Z

Request review from @bretbrownjr .

camio

Thanks for the PR! I'm excited about the use of VERIFY_INTERFACE_HEADER_SETS as that'll give us one more reason to avoid making static libraries when the code is header only (+CC @DeveloperPaul123)

It looks like gmock and gtest are being installed in addition to beman.exemplar (which they shouldn't). I observed a bunch of output like this in the ubuntu-gcc-werror output:

#18 [12/13] RUN cmake --install build --prefix /opt/beman.exemplar
#18 0.047 -- Install configuration: ""
#18 0.048 -- Installing: /opt/beman.exemplar/include
#18 0.048 -- Installing: /opt/beman.exemplar/include/gmock
#18 0.048 -- Installing: /opt/beman.exemplar/include/gmock/gmock-cardinalities.h
#18 0.049 -- Installing: /opt/beman.exemplar/include/gmock/gmock-matchers.h
#18 0.049 -- Installing: /opt/beman.exemplar/include/gmock/gmock-spec-builders.h
#18 0.050 -- Installing: /opt/beman.exemplar/include/gmock/gmock.h

Additionally, it looks like the header is being installed in lib/ instead of include/:

#18 0.072 -- Installing: /opt/beman.exemplar/lib/beman/exemplar/identity.hpp

camio · 2024-09-24T23:12:39Z

it looks like the header is being installed in lib/ instead of include/

I think the way to fix this is to remove the DESTINATION keyword from the install command

wusatosi · 2024-09-24T23:13:37Z

Thanks for the PR! I'm excited about the use of VERIFY_INTERFACE_HEADER_SETS as that'll give us one more reason to avoid making static libraries when the code is header only (+CC @DeveloperPaul123)

It looks like gmock and gtest are being installed in addition to beman.exemplar (which they shouldn't). I observed a bunch of output like this in the ubuntu-gcc-werror output:
#18 [12/13] RUN cmake --install build --prefix /opt/beman.exemplar
#18 0.047 -- Install configuration: ""
#18 0.048 -- Installing: /opt/beman.exemplar/include
#18 0.048 -- Installing: /opt/beman.exemplar/include/gmock
#18 0.048 -- Installing: /opt/beman.exemplar/include/gmock/gmock-cardinalities.h
#18 0.049 -- Installing: /opt/beman.exemplar/include/gmock/gmock-matchers.h
#18 0.049 -- Installing: /opt/beman.exemplar/include/gmock/gmock-spec-builders.h
#18 0.050 -- Installing: /opt/beman.exemplar/include/gmock/gmock.h
Additionally, it looks like the header is being installed in lib/ instead of include/:
#18 0.072 -- Installing: /opt/beman.exemplar/lib/beman/exemplar/identity.hpp

I was gonna ask about this as well, I think this behavior exist prior to this PR.

e. g. See: https://github.com/beman-project/exemplar/actions/runs/11016758495/job/30593042124#step:6:1 line ~400

camio · 2024-09-24T23:22:40Z

It looks like gmock and gtest are being installed

I don't understand why this is happening. When we call FetchContent_Declare for GTest, we use the EXCLUDE_FROM_ALL keyword. According to FetchContent docs, this is defined by "the documentation for the directory property EXCLUDE_FROM_ALL". When I go there it states "Any install rules defined in the subdirectory or below will be ignored when installing the parent directory." I wonder if it's a CMake bug.

camio · 2024-09-24T23:25:46Z

There's problem with FILE_PATTERN when matching the header file, is there a way to ask the FILE_PATTERN to search for the header file in a specific directory?

What do you mean by "FILE_PATTERN"?

Is there a way I can avoid using the INCLUDE_DIR variable?

Not that I know of.

Do we need to mention this in README?

I don't think this change is user-visible.

src/beman/exemplar/CMakeLists.txt

wusatosi · 2024-09-24T23:37:42Z

There's problem with FILE_PATTERN when matching the header file, is there a way to ask the FILE_PATTERN to search for the header file in a specific directory?

What do you mean by "FILE_PATTERN"?

For FILE_PATTERN, I was trying to see if I can do away with defining the absolute path to the identity.hpp, FILE_PATTERN on *.hpp seem to be the natural route, but it isn't working as it won't match anything from the base directory of the include folder (it seems to be searching from the source code folder).

Is there a way I can avoid using the INCLUDE_DIR variable?

Not that I know of.

Do we need to mention this in README?

I don't think this change is user-visible.

Thanks for the feedback.

DeveloperPaul123 · 2024-09-24T23:39:58Z

It looks like gmock and gtest are being installed

I don't understand why this is happening. When we call FetchContent_Declare for GTest, we use the EXCLUDE_FROM_ALL keyword. According to FetchContent docs, this is defined by "the documentation for the directory property EXCLUDE_FROM_ALL". When I go there it states "Any install rules defined in the subdirectory or below will be ignored when installing the parent directory." I wonder if it's a CMake bug.

Note that this is only the case in CMake 3.30+. Previous versions do not have this behavior and exemplar is using 3.24 as a minimum version. If we want to guarantee this behavior, maybe we should bump the minimum version.

DeveloperPaul123 · 2024-09-24T23:40:36Z

3.29 docs for EXCLUDE_FROM_ALL

wusatosi · 2024-09-25T01:11:25Z

It looks like gmock and gtest are being installed

I don't understand why this is happening. When we call FetchContent_Declare for GTest, we use the EXCLUDE_FROM_ALL keyword. According to FetchContent docs, this is defined by "the documentation for the directory property EXCLUDE_FROM_ALL". When I go there it states "Any install rules defined in the subdirectory or below will be ignored when installing the parent directory." I wonder if it's a CMake bug.

Ehhhh, this doesn't seem to be in the scope of this PR, I am not familiar with cmake so sorry I don't have anything to contribute for this. Does the rest of the pr look good?

bretbrownjr

This is a good PR. I'm tempted to land it, as is but it's probably worth being a little picky on an "examplar" project that will be used for generating Beman projects going forward.

bretbrownjr · 2024-09-25T03:49:46Z

src/beman/exemplar/CMakeLists.txt

-  DESTINATION ${CMAKE_INSTALL_LIBDIR})
-
-install(
-  DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/../../../include/
  DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}


The CMake 3.24 docs seem to indicate we can leave off DESTINATION because FILE_SET with the TYPE HEADERS will implicitly be installed into the INCLUDEDIR DESTINATION:
https://cmake.org/cmake/help/v3.24/command/install.html

I will test again tomorrow morning with this line removed, but I am pretty sure when I run CMake 3.26 locally without the destination argument it faults at install?

Edit: tested again, did not fault, I were wrong.

Ah I don't think removing this is correct. cmake --install no longer output the identity.hpp file, see latest CI run: https://github.com/beman-project/exemplar/actions/runs/11034273081/job/30647406013?pr=30#step:6:445 vs previous CI run: https://github.com/beman-project/exemplar/actions/runs/11024257637/job/30617095477#step:6:382 (Missing #18 0.073 -- Installing: /opt/beman.exemplar/include/beman/exemplar/identity.hpp)

The problem is that DESTINATION is being applied to everything being installed. To make it apply only to the file set, it must come after FILE_SET HEADERS. I tried this and it worked on cmake 3.30.1.

From the CMake docs:

The first <artifact-option>... group applies to target
:ref:Output Artifacts that do not have a dedicated group specified
later in the same call.

👌 would update later.

Oh, right. Good catch @camio. It helps to indent fields like DESTINATION so they are clearly "under" the FILE_SET it's modifying. Or you can split the install() command up into N more specific ones.

But I still swear that FILE_SET should imply INCLUDEDIR by default. Maybe @mathstuf can assist.

To be clear, I'm OK landing this PR with DESTINATION and following up on this detail later.

Done, could @camio or @bretbrownjr provide more info on what this fixes? cmake --install ... still installs gtest aside from the project headers. Is this intended for having multiple source-file groups? Just curious.

Done, could @camio or @bretbrownjr provide more info on what [moving DESTINATION below FILE_SET] fixes?

It fixes the issue where libbeman.exemplar.a was being placed in include/ instead of lib/.

bretbrownjr · 2024-09-25T03:51:27Z

.ci/docker/ubuntu.Dockerfile

@@ -30,5 +30,6 @@ ENV CC="$cc" CXX="$cxx" CMAKE_GENERATOR="Ninja" CMAKE_EXPORT_COMPILE_COMMANDS=on
 RUN ls -lR src
 RUN cmake -B build -S . "$cmake_args"
 RUN cmake --build build --verbose
+RUN cmake --build build --target all_verify_interface_header_sets


Not a big deal, but is the --verbose flag worth adding for the all_verify_interface_header_sets command? If we see a compiler error in a CI log, do we see enough detail to identify the relevant compilation commands?

Sure I can add the verbose flag. Logs are free.

#6 tries to remove the Dockerfiles. Maybe we should decide if we'll do that or not, as it may influence current PR.

I have not checked failure case but I don't think verbose provide any useful information, should we still add the verbose flag?

I can work on this later too but can you help me produce a case where the all_verify_interface_header_sets fails? I can go check the log and see if verbose provide more information.

For instance, I would expect the following to work in a normally-formed CMake library but fail an all_verify_interface_header_sets check.

// @file something.hpp struct something::Widget { // BUG: Uses std::vector but doesn't include <vector> std::vector vec; };

// @file something.cpp #include <vector> // something.hpp as expanded here gets vector defined for "free" // by the preceeding #include, so something.cpp compiles fine #include <something.hpp> namespace { size_t something::foobar(something::Widget const& widget) { return widget.vec.size(); } } // unnamed namespace

I just want to make sure the person looking at a failure log can tell:

That something.hpp is being checked with a specific compile command

(Something about building a temporary like $some_build_dir/something.hpp.cpp probably)

What the compile command is, because flags like header search paths can be relevant

Exactly what the problem is

If we get that with --verbose off, I'm happy. We can land a shorter log and everyone wins.

If we don't get it regardless of whether --verbose is on or off, let's make an upstream CMake issue. I wouldn't expect tweaking this would be tricky or expensive for them.

#6 tries to remove the Dockerfiles. Maybe we should decide if we'll do that or not, as it may influence current PR.

Since #6 is closed, no worries on this PR, right?

#6 tries to remove the Dockerfiles. Maybe we should decide if we'll do that or not, as it may influence current PR.

Since #6 is closed, no worries on this PR, right?

We shouldn't need to worry about that.

Without verbose Flag

⋊> ~/D/test-cmake cmake --build build --target verify_interface_header_sets [ 40%] Built target something_lib [ 60%] Generating verify_something.hpp.cpp [ 60%] Generating verify_something.hpp.cpp [ 80%] Building CXX object CMakeFiles/verify_something.dir/verify_something.hpp.cpp.o cc1plus: fatal error: /home/bradwu/Desktop/test-cmake/build/verify_something.hpp.cpp: No such file or directory compilation terminated. gmake[3]: *** [CMakeFiles/verify_something.dir/build.make:80: CMakeFiles/verify_something.dir/verify_something.hpp.cpp.o] Error 1 gmake[2]: *** [CMakeFiles/Makefile2:113: CMakeFiles/verify_something.dir/all] Error 2 gmake[1]: *** [CMakeFiles/Makefile2:146: CMakeFiles/verify_interface_header_sets.dir/rule] Error 2 gmake: *** [Makefile:150: verify_interface_header_sets] Error 2

With Verbose Flag

⋊> ~/D/test-cmake cmake --build build --target verify_interface_header_sets --verbose /home/linuxbrew/.linuxbrew/Cellar/cmake/3.26.3/bin/cmake -S/home/bradwu/Desktop/test-cmake -B/home/bradwu/Desktop/test-cmake/build --check-build-system CMakeFiles/Makefile.cmake 0 /usr/bin/gmake -f CMakeFiles/Makefile2 verify_interface_header_sets gmake[1]: Entering directory '/home/bradwu/Desktop/test-cmake/build' /home/linuxbrew/.linuxbrew/Cellar/cmake/3.26.3/bin/cmake -S/home/bradwu/Desktop/test-cmake -B/home/bradwu/Desktop/test-cmake/build --check-build-system CMakeFiles/Makefile.cmake 0 /home/linuxbrew/.linuxbrew/Cellar/cmake/3.26.3/bin/cmake -E cmake_progress_start /home/bradwu/Desktop/test-cmake/build/CMakeFiles 5 /usr/bin/gmake -f CMakeFiles/Makefile2 CMakeFiles/verify_interface_header_sets.dir/all gmake[2]: Entering directory '/home/bradwu/Desktop/test-cmake/build' /usr/bin/gmake -f CMakeFiles/something_lib.dir/build.make CMakeFiles/something_lib.dir/depend gmake[3]: Entering directory '/home/bradwu/Desktop/test-cmake/build' cd /home/bradwu/Desktop/test-cmake/build && /home/linuxbrew/.linuxbrew/Cellar/cmake/3.26.3/bin/cmake -E cmake_depends "Unix Makefiles" /home/bradwu/Desktop/test-cmake /home/bradwu/Desktop/test-cmake /home/bradwu/Desktop/test-cmake/build /home/bradwu/Desktop/test-cmake/build /home/bradwu/Desktop/test-cmake/build/CMakeFiles/something_lib.dir/DependInfo.cmake --color= gmake[3]: Leaving directory '/home/bradwu/Desktop/test-cmake/build' /usr/bin/gmake -f CMakeFiles/something_lib.dir/build.make CMakeFiles/something_lib.dir/build gmake[3]: Entering directory '/home/bradwu/Desktop/test-cmake/build' gmake[3]: Nothing to be done for 'CMakeFiles/something_lib.dir/build'. gmake[3]: Leaving directory '/home/bradwu/Desktop/test-cmake/build' [ 40%] Built target something_lib /usr/bin/gmake -f CMakeFiles/verify_something.dir/build.make CMakeFiles/verify_something.dir/depend gmake[3]: Entering directory '/home/bradwu/Desktop/test-cmake/build' [ 60%] Generating verify_something.hpp.cpp /home/linuxbrew/.linuxbrew/Cellar/cmake/3.26.3/bin/cmake -E echo #include\ <something.hpp> > /home/bradwu/Desktop/test-cmake/build/verify_something.hpp.cpp cd /home/bradwu/Desktop/test-cmake/build && /home/linuxbrew/.linuxbrew/Cellar/cmake/3.26.3/bin/cmake -E cmake_depends "Unix Makefiles" /home/bradwu/Desktop/test-cmake /home/bradwu/Desktop/test-cmake /home/bradwu/Desktop/test-cmake/build /home/bradwu/Desktop/test-cmake/build /home/bradwu/Desktop/test-cmake/build/CMakeFiles/verify_something.dir/DependInfo.cmake --color= gmake[3]: Leaving directory '/home/bradwu/Desktop/test-cmake/build' /usr/bin/gmake -f CMakeFiles/verify_something.dir/build.make CMakeFiles/verify_something.dir/build gmake[3]: Entering directory '/home/bradwu/Desktop/test-cmake/build' [ 60%] Generating verify_something.hpp.cpp /home/linuxbrew/.linuxbrew/Cellar/cmake/3.26.3/bin/cmake -E echo #include\ <something.hpp> > /home/bradwu/Desktop/test-cmake/build/verify_something.hpp.cpp [ 80%] Building CXX object CMakeFiles/verify_something.dir/verify_something.hpp.cpp.o /usr/bin/c++ -I/home/bradwu/Desktop/test-cmake -std=gnu++17 -MD -MT CMakeFiles/verify_something.dir/verify_something.hpp.cpp.o -MF CMakeFiles/verify_something.dir/verify_something.hpp.cpp.o.d -o CMakeFiles/verify_something.dir/verify_something.hpp.cpp.o -c /home/bradwu/Desktop/test-cmake/build/verify_something.hpp.cpp cc1plus: fatal error: /home/bradwu/Desktop/test-cmake/build/verify_something.hpp.cpp: No such file or directory compilation terminated. gmake[3]: *** [CMakeFiles/verify_something.dir/build.make:80: CMakeFiles/verify_something.dir/verify_something.hpp.cpp.o] Error 1 gmake[3]: Leaving directory '/home/bradwu/Desktop/test-cmake/build' gmake[2]: *** [CMakeFiles/Makefile2:113: CMakeFiles/verify_something.dir/all] Error 2 gmake[2]: Leaving directory '/home/bradwu/Desktop/test-cmake/build' gmake[1]: *** [CMakeFiles/Makefile2:146: CMakeFiles/verify_interface_header_sets.dir/rule] Error 2 gmake[1]: Leaving directory '/home/bradwu/Desktop/test-cmake/build' gmake: *** [Makefile:150: verify_interface_header_sets] Error 2

Verbose doesn't provide more useful information, and honestly the error log is pretty bad. The error fails because it cannot find the verify_something.hpp.cpp, even with verbose on nothing indicate the reason for failure to generate this file.

Tested on cmake version 3.26.3.

Can someone test this on newer cmake version? We should file an issue upstream if no more helpful error message is generated.

I tested on cmake version 3.30.3, same output, I will file a issue upstream, let's omit the verbose flag.

version 3.30.3 with verbose log

⋊> ~/D/test-cmake cmake --build build --verbose (base) 13:45:00 Change Dir: '/home/bradwu/Desktop/test-cmake/build' Run Build Command(s): /home/linuxbrew/.linuxbrew/Cellar/cmake/3.30.3/bin/cmake -E env VERBOSE=1 /usr/bin/gmake -f Makefile /home/linuxbrew/.linuxbrew/Cellar/cmake/3.30.3/bin/cmake -S/home/bradwu/Desktop/test-cmake -B/home/bradwu/Desktop/test-cmake/build --check-build-system CMakeFiles/Makefile.cmake 0 /home/linuxbrew/.linuxbrew/Cellar/cmake/3.30.3/bin/cmake -E cmake_progress_start /home/bradwu/Desktop/test-cmake/build/CMakeFiles /home/bradwu/Desktop/test-cmake/build//CMakeFiles/progress.marks /usr/bin/gmake -f CMakeFiles/Makefile2 all gmake[1]: Entering directory '/home/bradwu/Desktop/test-cmake/build' /usr/bin/gmake -f CMakeFiles/something_lib.dir/build.make CMakeFiles/something_lib.dir/depend gmake[2]: Entering directory '/home/bradwu/Desktop/test-cmake/build' cd /home/bradwu/Desktop/test-cmake/build && /home/linuxbrew/.linuxbrew/Cellar/cmake/3.30.3/bin/cmake -E cmake_depends "Unix Makefiles" /home/bradwu/Desktop/test-cmake /home/bradwu/Desktop/test-cmake /home/bradwu/Desktop/test-cmake/build /home/bradwu/Desktop/test-cmake/build /home/bradwu/Desktop/test-cmake/build/CMakeFiles/something_lib.dir/DependInfo.cmake "--color=" Dependencies file "CMakeFiles/something_lib.dir/something.cpp.o.d" is newer than depends file "/home/bradwu/Desktop/test-cmake/build/CMakeFiles/something_lib.dir/compiler_depend.internal". Consolidate compiler generated dependencies of target something_lib gmake[2]: Leaving directory '/home/bradwu/Desktop/test-cmake/build' /usr/bin/gmake -f CMakeFiles/something_lib.dir/build.make CMakeFiles/something_lib.dir/build gmake[2]: Entering directory '/home/bradwu/Desktop/test-cmake/build' gmake[2]: Nothing to be done for 'CMakeFiles/something_lib.dir/build'. gmake[2]: Leaving directory '/home/bradwu/Desktop/test-cmake/build' [ 40%] Built target something_lib /usr/bin/gmake -f CMakeFiles/verify_something.dir/build.make CMakeFiles/verify_something.dir/depend gmake[2]: Entering directory '/home/bradwu/Desktop/test-cmake/build' [ 60%] Generating verify_something.hpp.cpp /home/linuxbrew/.linuxbrew/Cellar/cmake/3.30.3/bin/cmake -E echo #include\ <something.hpp> > /home/bradwu/Desktop/test-cmake/build/verify_something.hpp.cpp cd /home/bradwu/Desktop/test-cmake/build && /home/linuxbrew/.linuxbrew/Cellar/cmake/3.30.3/bin/cmake -E cmake_depends "Unix Makefiles" /home/bradwu/Desktop/test-cmake /home/bradwu/Desktop/test-cmake /home/bradwu/Desktop/test-cmake/build /home/bradwu/Desktop/test-cmake/build /home/bradwu/Desktop/test-cmake/build/CMakeFiles/verify_something.dir/DependInfo.cmake "--color=" gmake[2]: Leaving directory '/home/bradwu/Desktop/test-cmake/build' /usr/bin/gmake -f CMakeFiles/verify_something.dir/build.make CMakeFiles/verify_something.dir/build gmake[2]: Entering directory '/home/bradwu/Desktop/test-cmake/build' [ 60%] Generating verify_something.hpp.cpp /home/linuxbrew/.linuxbrew/Cellar/cmake/3.30.3/bin/cmake -E echo #include\ <something.hpp> > /home/bradwu/Desktop/test-cmake/build/verify_something.hpp.cpp [ 80%] Building CXX object CMakeFiles/verify_something.dir/verify_something.hpp.cpp.o /usr/bin/c++ -I/home/bradwu/Desktop/test-cmake -std=gnu++17 -MD -MT CMakeFiles/verify_something.dir/verify_something.hpp.cpp.o -MF CMakeFiles/verify_something.dir/verify_something.hpp.cpp.o.d -o CMakeFiles/verify_something.dir/verify_something.hpp.cpp.o -c /home/bradwu/Desktop/test-cmake/build/verify_something.hpp.cpp cc1plus: fatal error: /home/bradwu/Desktop/test-cmake/build/verify_something.hpp.cpp: No such file or directory compilation terminated. gmake[2]: *** [CMakeFiles/verify_something.dir/build.make:80: CMakeFiles/verify_something.dir/verify_something.hpp.cpp.o] Error 1 gmake[2]: Leaving directory '/home/bradwu/Desktop/test-cmake/build' gmake[1]: *** [CMakeFiles/Makefile2:113: CMakeFiles/verify_something.dir/all] Error 2 gmake[1]: Leaving directory '/home/bradwu/Desktop/test-cmake/build' gmake: *** [Makefile:91: all] Error 2

This reverts commit f4ff6ac.

camio · 2024-09-25T19:13:50Z

[Fixing the issue where GTest is being installed] doesn't seem to be in the scope of this PR

I agree (and thanks @DeveloperPaul123 for pointing out that the behavior we want is in new versions of CMake!). I'll created #32 to fix this.

mathstuf

LGTM from a file set perspective.

camio

This PR looks good to land now.

wusatosi added 4 commits September 24, 2024 15:51

include folder is not working

26367d7

fixed include header

735a7e6

removed unnecessary directives

fc85080

update dockerfile to reflect cmake change

e2a8352

wusatosi requested review from bretbrownjr, camio, dietmarkuehl, neatudarius and steve-downey as code owners September 24, 2024 20:17

camio reviewed Sep 24, 2024

View reviewed changes

DeveloperPaul123 reviewed Sep 24, 2024

View reviewed changes

src/beman/exemplar/CMakeLists.txt Outdated Show resolved Hide resolved

switch to CMAKE_INSTALL_LIBDIR

6edc629

DeveloperPaul123 mentioned this pull request Sep 25, 2024

Minor build setup changes bemanproject/inplace_vector#6

Merged

bretbrownjr reviewed Sep 25, 2024

View reviewed changes

wusatosi and others added 2 commits September 25, 2024 09:40

remove INSTALL directive

f4ff6ac

Revert "remove INSTALL directive"

62f37d9

This reverts commit f4ff6ac.

wusatosi requested review from camio and bretbrownjr September 27, 2024 06:58

update DESTINATION location

b9b56e0

mathstuf approved these changes Sep 27, 2024

View reviewed changes

camio approved these changes Sep 28, 2024

View reviewed changes

camio merged commit 1ce5d88 into bemanproject:main Sep 28, 2024
13 checks passed

camio mentioned this pull request Dec 5, 2024

remove unnecessary comments #88

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement Use CMake Header File Sets #30

Implement Use CMake Header File Sets #30

wusatosi commented Sep 24, 2024

wusatosi commented Sep 24, 2024

camio left a comment

camio commented Sep 24, 2024

wusatosi commented Sep 24, 2024 •

edited

Loading

camio commented Sep 24, 2024

camio commented Sep 24, 2024

wusatosi commented Sep 24, 2024

DeveloperPaul123 commented Sep 24, 2024

DeveloperPaul123 commented Sep 24, 2024

wusatosi commented Sep 25, 2024

bretbrownjr left a comment

bretbrownjr Sep 25, 2024

This comment was marked as outdated.

wusatosi Sep 25, 2024 •

edited

Loading

wusatosi Sep 25, 2024

wusatosi Sep 25, 2024

camio Sep 25, 2024

wusatosi Sep 25, 2024

bretbrownjr Sep 25, 2024

wusatosi Sep 27, 2024

camio Sep 28, 2024

bretbrownjr Sep 25, 2024

wusatosi Sep 25, 2024

neatudarius Sep 25, 2024

wusatosi Sep 25, 2024 •

edited

Loading

wusatosi Sep 25, 2024 •

edited

Loading

bretbrownjr Sep 25, 2024 •

edited

Loading

bretbrownjr Sep 25, 2024

wusatosi Sep 27, 2024 •

edited

Loading

wusatosi Sep 27, 2024 •

edited

Loading

wusatosi Sep 27, 2024

camio commented Sep 25, 2024 •

edited

Loading

mathstuf left a comment

camio left a comment

Implement Use CMake Header File Sets #30

Implement Use CMake Header File Sets #30

Conversation

wusatosi commented Sep 24, 2024

wusatosi commented Sep 24, 2024

camio left a comment

Choose a reason for hiding this comment

camio commented Sep 24, 2024

wusatosi commented Sep 24, 2024 • edited Loading

camio commented Sep 24, 2024

camio commented Sep 24, 2024

wusatosi commented Sep 24, 2024

DeveloperPaul123 commented Sep 24, 2024

DeveloperPaul123 commented Sep 24, 2024

wusatosi commented Sep 25, 2024

bretbrownjr left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment was marked as outdated.

wusatosi Sep 25, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wusatosi Sep 25, 2024 • edited Loading

Choose a reason for hiding this comment

wusatosi Sep 25, 2024 • edited Loading

Choose a reason for hiding this comment

bretbrownjr Sep 25, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wusatosi Sep 27, 2024 • edited Loading

Choose a reason for hiding this comment

wusatosi Sep 27, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

camio commented Sep 25, 2024 • edited Loading

mathstuf left a comment

Choose a reason for hiding this comment

camio left a comment

Choose a reason for hiding this comment

wusatosi commented Sep 24, 2024 •

edited

Loading

wusatosi Sep 25, 2024 •

edited

Loading

wusatosi Sep 25, 2024 •

edited

Loading

wusatosi Sep 25, 2024 •

edited

Loading

bretbrownjr Sep 25, 2024 •

edited

Loading

wusatosi Sep 27, 2024 •

edited

Loading

wusatosi Sep 27, 2024 •

edited

Loading

camio commented Sep 25, 2024 •

edited

Loading