Minor build setup changes #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeveloperPaul123
force-pushed
the
fix/small-build-setup-changes
branch
from
335f226
to
42d0dd7
Compare
camio
reviewed
Sep 23, 2024
Ensure that C++23 is required and add a basic gitignore.
DeveloperPaul123
force-pushed
the
fix/small-build-setup-changes
branch
from
676d68e
to
0fd0c34
Compare
|
Ok I removed the static library and added an interface target. If you want @camio I can wait for changes to be implemented in beman-project/exemplar#30 and then integrate those in this project. Or that can just be a follow up PR. Note that the install rules in this project are still broken. |
camio
reviewed
Sep 26, 2024
I'm okay with merging this one and doing the others in a follow up PR. Thanks for the contribution! |
Co-authored-by: David Sankel <[email protected]>
camio
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if these changes are in line with the
Bemanstandards, but I found the CMakeLists changes to be necessary to get the project to build. Also I think it's fairly common to reserve theoutorbuildfolder in the source directory for builds, especially with build setups that useCMakePresets.jsonorCMakeUserPresets.json.If there are changes I need to make to get this accepted please let me know. Thanks!