Merge pull request #4 from gulp-bem/linting

Chore: add eslint

.eslintrc

@@ -0,0 +1,9 @@
+{
+    "parserOptions": {
+        "ecmaVersion": 6
+    },
+    "env": {
+        "node": true
+    },
+    "extends": "pedant"
+}

error.js

@@ -6,9 +6,9 @@ var util = require('util');
 var format = util.format;
 
 /**
- * @param {Object} err
- * @param {String} code
- * @param {String} filepath
+ * @param {{description: string, column: number, lineNumber: number}} err - Error data
+ * @param {String} code - Code sample
+ * @param {String} filepath - Path to the file
  * @return {String|Object}
  */
 module.exports = function (err, code, filepath) {

index.js

@@ -19,7 +19,8 @@ var pluginName = path.basename(__dirname);
 /**
  * bem-xjst templates compiler.
  *
- * @param {Object} options
+ * @param {{extension: string}} options - Options for generator.
+ * @param {String} engine - bemhtml or bemtree.
  * @returns {Stream}
  */
 module.exports = function(options, engine) {
@@ -64,7 +65,7 @@ module.exports.bemtree = function(options) {
 };
 
 module.exports.toHtml = function(tmpl) {
-  return geval().pipe(through.obj(function(bemjsonFile, encoding, callback) {
+  return geval().pipe(through.obj(function(bemjsonFile, _, callback) {
     if (bemjsonFile.isNull()) {
       return callback(null, bemjsonFile);
     }
@@ -80,19 +81,19 @@ module.exports.toHtml = function(tmpl) {
     var n = 0;
 
     tmpl
-      .pipe(through.obj(function(file, encoding, callback){
+      .pipe(through.obj(function(file, __, tmplCallback){
         if (file.isStream()) {
-          return callback(new PluginError(pluginName, 'Substreaming not supported'));
+          return tmplCallback(new PluginError(pluginName, 'Substreaming not supported'));
         }
-        return callback(null, file);
+        return tmplCallback(null, file);
       }))
       .pipe(geval())
       .pipe(through.obj(function(file) {
         if (file.isNull()) {
           return callback(null, file);
         }
 
-        var html = tryCatch(_ => file.data.apply(bemjsonFile.data), callback);
+        var html = tryCatch(() => file.data.apply(bemjsonFile.data), callback);
         if (!html) {
           return callback(null);
         }
@@ -108,6 +109,13 @@ module.exports.toHtml = function(tmpl) {
     }));
 };
 
+/**
+ * Try to run function and call handler if it throws.
+ *
+ * @param {Function} fn - Unsafe function body
+ * @param {Function} cb - Error handler
+ * @returns {*}
+ */
 function tryCatch(fn, cb) {
   try {
     return fn();

package.json

@@ -38,6 +38,8 @@
     "vinyl": "^1.1.1"
   },
   "devDependencies": {
+    "eslint": "^2.8.0",
+    "eslint-config-pedant": "^0.3.0",
     "expect.js": "^0.3.1",
     "mocha": "^2.1.0"
   }

test/.eslintrc

@@ -0,0 +1,9 @@
+{
+    "extends": "../.eslintrc",
+    "env": {
+        "mocha": true
+    },
+    "rules": {
+        "no-eval": [1]
+    }
+}