submit: add support for checking imat tokens #1
Conversation
| return nil | ||
| } | ||
| } | ||
|
|
||
| if p.AppName == "booper" { | ||
| if gplaySpamEmailRegex.MatchString(p.Data["user_id"]) { | ||
| log.Println("Dropping report from", p.Data["user_id"]) |
There was a problem hiding this comment.
I think we still need this filter
There was a problem hiding this comment.
Why? It seems like a bad heuristic. What if someone just happens to have a bunch of numbers at the end of their gmail account?
There was a problem hiding this comment.
We don't want to be spammed by the google play testers in linear, they're still sending over a dozen bug reports per day
There was a problem hiding this comment.
I used to have a gmail account with 7 numbers at the end.
I went ahead and added this check back in, but this might be something we want to revisit.
| } | ||
|
|
||
| // All of iMessage on Android is on beeper.com | ||
| apiServerURL, ok := s.cfg.APIServerURLs["beeper.com"] |
There was a problem hiding this comment.
I don't think that's strictly true, this should probably use the current env api server (then dev/staging booper can be pointed at dev/staging rageshake)
There was a problem hiding this comment.
Oh wait, we might not be telling rageshake which env it is in 🤔 I guess hardcoding beeper.com for now is easier
There was a problem hiding this comment.
Do dev/staging booper even exist? As far as I can tell, everyone is on the same app.
There was a problem hiding this comment.
Not sure if there's a switcher, but booper used to be pointed at staging until a week ago or something
Signed-off-by: Sumner Evans <[email protected]>
Signed-off-by: Sumner Evans <[email protected]>
sumnerevans
force-pushed
the
sumner/be-19796
branch
from
3245980 to
86578bd
Compare
Related beeper-services PR: https://github.com/beeper/beeper-services/pull/152