⬆️ Upgrade to ImageSharp 3 #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomrijnbeek
added
dependencies
paulcscharf
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What's this?
Upgrades ImageSharp to 3.1.3. This includes updating some method calls to their new signatures.
🔗 Relationships
See #74
🔍 Why do we want this?
There is a security vulnerability in ImageSharp 2 and it keeps trying to tell me everywhere 😛
🏗 How is it done?
Updated the package, then resolved all build errors.
💥 Breaking changes
Might break compatibility with other people who use ImageSharp 2 still. TD uses 3 though.
🔬 Why not another way?
Need to bump it somehow.
💡 Review hints
I've run a clean build of TD with this Bearded.Graphics version and it builds and runs fine. Things are drawn as expected.