Skip to content

Commit

Permalink
Back out "drop support for 1.6; revert CSR matrix init in tests"
Browse files Browse the repository at this point in the history
This backs out commit 187e66c.
  • Loading branch information
haberdashPI committed Jan 30, 2025
1 parent 187e66c commit 051d096
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/CI-OndaEDFSchemas.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
fail-fast: false
matrix:
version:
- "min"
- "1.6"
- "1"
os:
- ubuntu-latest
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/CI.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
fail-fast: false
matrix:
version:
- "min"
- "1.6"
- "1"
os:
- ubuntu-latest
Expand All @@ -45,3 +45,4 @@ jobs:
file: lcov.info
flags: OndaEDF.jl
token: ${{ secrets.CODECOV_TOKEN }}

2 changes: 1 addition & 1 deletion OndaEDFSchemas.jl/Project.toml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ UUIDs = "cf7118a7-6976-5b1a-9a39-7adc72f591a4"
[compat]
Legolas = "0.5.5"
Onda = "0.15"
julia = "1.10"
julia = "1.6"

[extras]
Arrow = "69666777-d1a9-59fb-9406-91d4454c9d45"
Expand Down
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ StableRNGs = "1"
StatsBase = "0.33, 0.34"
Tables = "1.4"
TimeSpans = "0.3, 1"
julia = "1.10"
julia = "1.6"

[extras]
FilePathsBase = "48062228-2e41-5def-b9a4-89aafe57970f"
Expand Down
4 changes: 3 additions & 1 deletion test/export.jl
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,9 @@
@testset "Record metadata" begin
function change_sample_rate(samples; sample_rate)
info = SamplesInfoV2(Tables.rowmerge(samples.info; sample_rate=sample_rate))
new_data = similar(samples.data, 0, Onda.index_from_time(sample_rate, Onda.duration(samples)) - 1)
# sparse CSC but for wide data we have a huge column pointer
# so transposing to get sparse CSR
new_data = spzeros(eltype(samples.data), Onda.index_from_time(sample_rate, Onda.duration(samples)) - 1, channel_count(samples))'
return Samples(new_data, info, samples.encoded; validate=false)
end

Expand Down

0 comments on commit 051d096

Please sign in to comment.