Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Enable SMTP Authentication in Tenant UI #974

Merged
merged 7 commits into from
Feb 5, 2024

Conversation

i5okie
Copy link
Contributor

@i5okie i5okie commented Jan 4, 2024

Enable using authentication with SMTP

Nodemailer used in Tenant UI supports using authentication. This PR extends the code to allow setting secure, and providing user and password variables via the Helm values.

For additional information refer to the nodemailer documentation: https://nodemailer.com/smtp/#authentication

Thanks @loneil for your help!

@i5okie i5okie requested review from esune and loneil January 4, 2024 18:48
@i5okie i5okie self-assigned this Jan 4, 2024
@loneil
Copy link
Collaborator

loneil commented Jan 4, 2024

To test this on the deployed PR we can temporarily set reservation.auto_approve in from plugin-config.yml in the config-map to false (or update it in values-pr to false and redeploy). Then reservation requests on the PR will send emails.

Can test out when deployment goes through but looking at code it seems ok. Probably good global setting to have though don't think we'll ever need this as we'd likely always be using the gov smtp server in OCP where it doesn't need auth?

esune
esune previously approved these changes Jan 9, 2024
Copy link
Member

@esune esune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good assuming the testing with no auth credentials yields positive results. @loneil it's true that for BCGov OCP we would not need the auth credentials, but it's nice to have the option 😉

Signed-off-by: Ivan Polchenko <[email protected]>
@i5okie
Copy link
Contributor Author

i5okie commented Feb 5, 2024

Works. Tested with reservation.auto_approve set to false as per @loneil's comment.

Copy link
Collaborator

@loneil loneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Tried out locally on VPN with secure false to confirm emails send

@i5okie i5okie merged commit 1b6abf5 into main Feb 5, 2024
11 checks passed
@loneil loneil deleted the feature/ui-nodemailer-auth branch May 3, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants