-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Enable SMTP Authentication in Tenant UI #974
Conversation
Deployment URLs ready for review. |
To test this on the deployed PR we can temporarily set Can test out when deployment goes through but looking at code it seems ok. Probably good global setting to have though don't think we'll ever need this as we'd likely always be using the gov smtp server in OCP where it doesn't need auth? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good assuming the testing with no auth credentials yields positive results. @loneil it's true that for BCGov OCP we would not need the auth credentials, but it's nice to have the option 😉
c8be705
to
7584ddc
Compare
7584ddc
to
fd039a6
Compare
66f929d
to
3fd370e
Compare
Signed-off-by: Ivan Polchenko <[email protected]>
Signed-off-by: Ivan Polchenko <[email protected]>
Signed-off-by: Ivan Polchenko <[email protected]>
Signed-off-by: Ivan Polchenko <[email protected]>
Signed-off-by: Ivan Polchenko <[email protected]>
Signed-off-by: Ivan Polchenko <[email protected]>
3fd370e
to
32b9672
Compare
Signed-off-by: Ivan Polchenko <[email protected]>
Works. Tested with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Tried out locally on VPN with secure false to confirm emails send
Enable using authentication with SMTP
Nodemailer used in Tenant UI supports using authentication. This PR extends the code to allow setting
secure
, and providinguser
andpassword
variables via the Helm values.For additional information refer to the
nodemailer
documentation: https://nodemailer.com/smtp/#authenticationThanks @loneil for your help!