-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tenant Issuer Config Fixes #748
Conversation
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
…into tenant_config_fix
…config_fix Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
Deployment URLs ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to create a tenant successfully. The profile page does not allow the tenant to connect to an endorser or publish a did since auto_issuer
is set to false - that is good. I changed the value of auto_issuer
to true in the argfile and restarted the container: on startup, aca-py still loads the auto issuer flag as False
, even if the mounted config file is set to true.
Is this for |
@shaangill025 you are right. The log statement relates to the innkeeper tenant, which only has admin role and will not connect to an endorser or publish a DID. I also apparently had restarted the wrong pod, after restarting the correct one and creating a new tenant everything works as expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested new tenant creation as well as clearing existing settings, everything works as expected 👍🏻
👍 Did a quick test of this as well after getting back today by creating a new temp PR with the helm val set to true and all the Tenant UI/Innkeeper behaviour works as I'd expect. Created a new tenant in DEV as well after this was deployed (where the flag is false) and that is still working as expected too. Great stuff! Probably need to decide if we'd want this flag set to true in pull request or "lower" envs by default in the helm vals as well. |
Reopening #737 here as there were issues in the PR development environment after changing
self_issuer_permission
toauto_issuer
inTenantRecord
.