Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tenant Issuer Config Fixes #748

Merged
merged 10 commits into from
Aug 8, 2023
Merged

Tenant Issuer Config Fixes #748

merged 10 commits into from
Aug 8, 2023

Conversation

shaangill025
Copy link
Contributor

Reopening #737 here as there were issues in the PR development environment after changing self_issuer_permission to auto_issuer in TenantRecord.

@shaangill025 shaangill025 temporarily deployed to development August 8, 2023 17:30 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Aug 8, 2023

Copy link
Member

@esune esune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to create a tenant successfully. The profile page does not allow the tenant to connect to an endorser or publish a did since auto_issuer is set to false - that is good. I changed the value of auto_issuer to true in the argfile and restarted the container: on startup, aca-py still loads the auto issuer flag as False, even if the mounted config file is set to true.

@shaangill025
Copy link
Contributor Author

I was able to create a tenant successfully. The profile page does not allow the tenant to connect to an endorser or publish a did since auto_issuer is set to false - that is good. I changed the value of auto_issuer to true in the argfile and restarted the container: on startup, aca-py still loads the auto issuer flag as False, even if the mounted config file is set to true.

Is this for traction_innkeeper, that is by design? New tenants created after setting auto_issuer to true should reflect that change in logs and tenant-ui [tested now locally using scripts].

@esune
Copy link
Member

esune commented Aug 8, 2023

@shaangill025 you are right. The log statement relates to the innkeeper tenant, which only has admin role and will not connect to an endorser or publish a DID. I also apparently had restarted the wrong pod, after restarting the correct one and creating a new tenant everything works as expected.

Copy link
Member

@esune esune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested new tenant creation as well as clearing existing settings, everything works as expected 👍🏻

@esune esune merged commit 30131e8 into main Aug 8, 2023
22 checks passed
@esune esune temporarily deployed to development August 8, 2023 22:05 — with GitHub Actions Inactive
@esune esune deleted the tenant_config_fix branch August 8, 2023 22:05
@loneil
Copy link
Collaborator

loneil commented Aug 9, 2023

👍 Did a quick test of this as well after getting back today by creating a new temp PR with the helm val set to true and all the Tenant UI/Innkeeper behaviour works as I'd expect. Created a new tenant in DEV as well after this was deployed (where the flag is false) and that is still working as expected too. Great stuff!

Probably need to decide if we'd want this flag set to true in pull request or "lower" envs by default in the helm vals as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants