Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try out 0.9.0rc #729

Merged
merged 3 commits into from
Jul 25, 2023
Merged

Try out 0.9.0rc #729

merged 3 commits into from
Jul 25, 2023

Conversation

loneil
Copy link
Collaborator

@loneil loneil commented Jul 21, 2023 •
edited
Loading

  1. Update acapy image to 0.9.0rc https://github.com/hyperledger/aries-cloudagent-python/pkgs/container/aries-cloudagent-python/111618235?tag=py3.9-0.9.0-rc0
  2. Update plugin dependencies to https://pypi.org/project/aries-cloudagent/0.9.0rc0/

@loneil
Update acapy version
a54e014 
Signed-off-by: Lucas ONeil <[email protected]>
@loneil loneil temporarily deployed to development July 21, 2023 20:47 — with GitHub Actions Inactive
@github-actions
Copy link

Deployment Resource Location
Traction
Tenant UI https://pr-729-tenant-ui-dev.apps.silver.devops.gov.bc.ca
Innkeeper UI https://pr-729-tenant-ui-dev.apps.silver.devops.gov.bc.ca/innkeeper
Aca-Py
Admin Swagger https://pr-729-traction-acapy-admin-dev.apps.silver.devops.gov.bc.ca/api/doc
Tenant Proxy Swagger https://pr-729-traction-tenant-proxy-dev.apps.silver.devops.gov.bc.ca/api/doc

Deployment URLs ready for review.

@loneil
Copy link
Collaborator Author

loneil commented Jul 21, 2023

Tenant
9ba4c87b-e991-4d4f-827f-989006415b71
9ba4c87b-e991-4d4f-827f-989006415b71

@loneil
Copy link
Collaborator Author

loneil commented Jul 21, 2023 •
edited
Loading

Current state here, back to creds ending up abandoned

Different error message than 0.8.2 askar update attempt though (which was working with 0.8.3pre image)
When issuing/accepting, get "error_msg": "Error creating credential. Missing tails file path.",

So schemas and cred defs create fine, they offer over to the connection, but on accept it's back to the issuer getting this error in the abandoned state.

But the tails files are getting created there this time
image

Need more investigation

@loneil loneil mentioned this pull request Jul 21, 2023
Closed
@esune
Updated mismatched dependency
3bd5e3c 
Signed-off-by: Emiliano Suñé <[email protected]>
@esune
Copy link
Member

esune commented Jul 24, 2023

It turns out the multitenant_provider was pulling-in an old version of indy-credx and that was causing a dependency mismatch between ACA-Py and the plugin. Updating the plugin dependency to match ACA-Py fixes issues and I have been able to (on localhost so far):

  • Connect to endorser
  • Publish my DID
  • Connect to a mobile wallet
  • Create a schema
  • Create a CredDef with revocation enabled
  • Issue a credential
  • Revoke a credential

I think this is probably good enough as smoke test to go ahead and approve/wrap-this up?

@esune esune temporarily deployed to development July 24, 2023 19:46 — with GitHub Actions Inactive
usingtechnology
usingtechnology approved these changes Jul 25, 2023
View reviewed changes
Copy link
Collaborator

@usingtechnology usingtechnology left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - the only explicit indy-credx is in multitenant_provider, and all the other plugins should be ok with the new lock files that pick up the correct version due to the ACA-Py version.

@esune esune temporarily deployed to development July 25, 2023 17:25 — with GitHub Actions Inactive
@esune esune merged commit 2c6e437 into main Jul 25, 2023
11 checks passed
@esune esune temporarily deployed to development July 25, 2023 18:28 — with GitHub Actions Inactive
@esune esune deleted the feature/90Update branch July 25, 2023 18:28
@esune esune mentioned this pull request Jul 25, 2023
Closed
loneil
loneil commented Jul 27, 2023
View reviewed changes
plugins/multitenant_provider/pyproject.toml
python-dateutil = "^2.8.2"
bcrypt = "^4.0.1"
mergedeep = "^1.3.4"
aries-askar = "^0.2.9"
typing-extensions = "4.0.0"
indy-vdr = "^0.3.4"
indy-credx = "^0.3.3"
indy-credx = "^1.0.0"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for finding this to be the issue @esune 🎈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@usingtechnology usingtechnology usingtechnology approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@loneil @esune @usingtechnology