-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 0.8.3 acapy image and python versions #703
Conversation
Deployment URLs ready for review. |
Current point blocking issuing revocable creds, tails file will not create
|
a12d6b0
to
e44978a
Compare
e44978a
to
34abb83
Compare
This will need the new 0.8.3 image with the |
Signed-off-by: Lucas ONeil <[email protected]>
Signed-off-by: Lucas ONeil <[email protected]>
ace5794
to
de48675
Compare
Signed-off-by: Lucas ONeil <[email protected]>
Looks good to me, but I’m not at the right level to give the approval. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we explicitly not supporting python 3.10/3.11 in pyproject.toml
?
Signed-off-by: Lucas ONeil <[email protected]>
I'd included that stuff over from Sherman's updates to the plugin python base images which switched from 3.6 to 3.9 images so I assume the goal is to keep everything in line to a certain version? |
@usingtechnology any input here? I am fine leaving just 3.9 if that is what we will be enforcing. |
i only limited it because the base images were at 3.9, seems safer to make that the same in the code. Wouldn't want someone writing code or bringing in a dependency that won't run on production images. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
This pull request:
Changes are based on work @usingtechnology did in PR 684 but isolated and expanded on here to troubleshoot issues with the 0.8.2 askar-only image
Prior to 0.8.2 Traction was using
bcgovimages/aries-cloudagent:py36-1.16-1_0.8.1
We are updating to use ghcr releases instead.
Initially tried upgrading to
ghcr.io/hyperledger/aries-cloudagent-python:py3.9-0.8.2
but this broke revocable credential creation. See discussionsopenwallet-foundation/acapy#2307
openwallet-foundation/acapy#2308
We will use the prerelease image cut with the
indy_client
fix as discussed for the time being until 0.9ghcr.io/hyperledger/aries-cloudagent-python:py3.9-0.8.3-pre
I've regression tested the environment here with this 0.8.3 release and it fixes the revocable creds (tails folder) problem and passes other functionality.
Issuer
f16d5181-5069-4c04-99b5-faac6dda9faa
38a720bd-1432-49d8-9557-541a6d4cab03
Non-Issuer
03490cb8-09e2-40f5-a4ef-0bd2bf6826c8
2fa1d27e-419e-46c5-8cd6-35aad9fdd0ce