Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE][INSPECT-#292] - Add a 'Add other waterbody' Button to the Waterbody Picker Table #293

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

davidclaveau
Copy link
Contributor

@davidclaveau davidclaveau commented Feb 27, 2024

Pull Request Standards

  • The title of the PR is accurate
  • The title includes the type of change [HOTFIX, FEATURE, etc]
  • The PR title includes the ticket number in format of [INSPECT-###]
  • Documentation is updated to reflect change

Description

This PR includes the following proposed change(s):

  • Add a button to the bottom of the Waterbody picker table to allow users to more easily add an 'other' waterbody
    • When a user clicks the 'Add other waterbody not listed' button, they are immediately shown the UI to add the 'other' waterbody manually (existing functionality).
  • This new button resides in a new footer container in the waterbody picker table.
  • Also a small fix was made to the margins for the header in the waterbody picker table to remove whitespace; needed to move Select, Back, and Title items down slightly in the header container to accommodate margin fix.

Copy link
Collaborator

@LocalNewsTV LocalNewsTV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

@davidclaveau davidclaveau merged commit 07121d9 into master Feb 27, 2024
1 check passed
@davidclaveau davidclaveau deleted the inspect-292-other-waterbody-entry branch February 27, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "Other waterbody" button to Waterbody dropdown to more easily add manual entries
2 participants