Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INV-254] FEATURE** Blow by data capture enhancement #280

Merged
merged 18 commits into from
Jan 25, 2024
Merged

[INV-254] FEATURE** Blow by data capture enhancement #280

merged 18 commits into from
Jan 25, 2024

Conversation

LocalNewsTV
Copy link
Collaborator

Pull Request Standards

  • The title of the PR is accurate
  • The title includes the type of change [HOTFIX, FEATURE, etc]
  • The PR title includes the ticket number in format of [INSPECT-###]
  • Documentation is updated to reflect change

Description

This PR includes the following proposed change(s):

  • Integrated changes from the retroactive shift start date and applied it to the Blowby instances
  • Enhanced Blowby data capture from using counters to simplified form

image
image
image

LocalNewsTV and others added 18 commits January 3, 2024 10:13
@LocalNewsTV
WIP Enhanced blowby capture
c5cf53b
@LocalNewsTV
Positioned Blowby correctly in view
6b46500
@LocalNewsTV
Added Add/Delete functionality. Pages reload when blowby added/removed
8686bc1
@davidclaveau
wip - submit and post to LUCY backend
9d12c86
@davidclaveau
wip - add additional documentation, remove obsolete shiftId on blowby…
dd91e5f 
… model
@LocalNewsTV
Put back the "Boats Inspected" toggle
af3ea43
@LocalNewsTV
Remove remnants of inspections, corrected to blowbys
4196cac
@LocalNewsTV
Added modal for adding Blowbys to shift
7a163ff
@davidclaveau
update to add blowByTime as timestamp format
e4db993
@davidclaveau
add validation to blowby, fix button style, hide button if not draft
848f453
@LocalNewsTV
Added refresh when new blowby added, removed validation check on repo…
1b5d9ee 
…rtedToRapp, cleaned table
@LocalNewsTV
Added New Entry/Edit logic to Blowby captures
57a0e1c
@LocalNewsTV
Merge branch 'master' of https://github.com/bcgov/invasivesBC-mussels…
c5f4fc2 
…-iOS into feature/blowby-enhancements
@LocalNewsTV
Fixed duplications made during merge
ccb5d2b
@LocalNewsTV
Added recursive date functionality to Blowbys
495ef06
@LocalNewsTV
corrected date change causing crash
3e6d1ab
@LocalNewsTV
Accidental commit of URL changes
e644a8e
@LocalNewsTV
Add documentation to new files and functions
5bf9a89
@davidclaveau davidclaveau marked this pull request as ready for review January 25, 2024 21:47
@davidclaveau davidclaveau merged commit a456e33 into master Jan 25, 2024
1 check passed
@davidclaveau davidclaveau deleted the feature/blowby-enhancements branch January 25, 2024 21:53
@davidclaveau davidclaveau linked an issue Jan 26, 2024 that may be closed by this pull request
enhancing blow by data captured #254
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidclaveau davidclaveau davidclaveau approved these changes

Assignees
No one assigned
Labels
Frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

enhancing blow by data captured
2 participants
@LocalNewsTV @davidclaveau