Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FORMS-784: Fix for fields filtering for single row export option 3 #892

Merged
merged 13 commits into from
Aug 16, 2023

Conversation

bcvesalink
Copy link
Contributor

Description

The fix which adding the filtering fields upon the export for Option #3 Single row export

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have run the npm script lint on the frontend and backend
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have approval from the product owner for the contribution in this pull request

Further comments

@bcvesalink bcvesalink self-assigned this Jul 14, 2023
@github-actions
Copy link

github-actions bot commented Jul 14, 2023

Coverage Report (Application)

Totals Coverage
Statements: 41.05% ( 2458 / 5988 )
Methods: 36.14% ( 305 / 844 )
Lines: 46.74% ( 1657 / 3545 )
Branches: 31.02% ( 496 / 1599 )

@github-actions
Copy link

github-actions bot commented Jul 14, 2023

Coverage Report (Frontend)

Totals Coverage
Statements: 69.87% ( 1069 / 1530 )
Methods: 66.43% ( 188 / 283 )
Lines: 74.5% ( 751 / 1008 )
Branches: 54.39% ( 130 / 239 )

@bcvesalink bcvesalink changed the title fix: add fields filtering for single row export option FORMS-784: Fix for fields filtering for single row export option 3 Aug 10, 2023
@WalterMoar
Copy link
Collaborator

I found a small problem with datagrids: the number of columns for a datagrid only depends on the last submission. To reproduce:

  1. Have a form with a datagrid containing a single text field

  2. Submit with three rows in the datagrid, then export

image
  1. Submit with one row in the datagrid, then export
image

Is it only looking at the final submission for the fields? I think it will need to look at all submissions, which may also fix #536

@bcvesalink
Copy link
Contributor Author

bcvesalink commented Aug 10, 2023

I found a small problem with datagrids: the number of columns for a datagrid only depends on the last submission. To reproduce:

Have a form with a datagrid containing a single text field

Submit with three rows in the datagrid, then export #536

good call, looking into it

@WalterMoar WalterMoar self-requested a review August 15, 2023 22:05
WalterMoar
WalterMoar previously approved these changes Aug 15, 2023
Copy link
Collaborator

@WalterMoar WalterMoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and fixes GitHub Issue 536 too!

@WalterMoar WalterMoar dismissed their stale review August 15, 2023 22:08

Tests failing

@WalterMoar WalterMoar self-requested a review August 15, 2023 22:08
@bcvesalink bcvesalink merged commit ac553e7 into master Aug 16, 2023
11 checks passed
@bcvesalink bcvesalink deleted the FORMS-784-export-fields-filter-bug branch August 16, 2023 15:49
@WalterMoar WalterMoar mentioned this pull request Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants