-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forms-396_filter_bc_geo_address_output #874
Forms-396_filter_bc_geo_address_output #874
Conversation
…ed-form-service into FORMS-396_Filter_BC_GeoAddress_Output
Forms 396 filter bc geo address output
Update app.dc.yaml
relative path test
change url path to relative path
Update action.yaml
Update action.yaml
test relative path
test url relative path
test relative url
relative path checks
Update action.yaml
…ed-form-service into FORMS-396_Filter_BC_GeoAddress_Output
…ed-form-service into FORMS-396_Filter_BC_GeoAddress_Output
update branch with upstream master branch
…omponent Removed the Address 1, Address 2, City, Country, Province and Postal textfields from both BC Address Component and Simple BC Address Component
remove unused textfields
Removed disabled property from both BC Address and Simple BC Address response property and display value property
removed disabled property
let searchAddresses = await geoAddressService.addressQuerySearch(query); | ||
|
||
if (searchAddresses?.features && Array.isArray(searchAddresses.features)) { | ||
await searchAddresses.features.forEach((element) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@timisenco2015 why would we need await
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was returning empty addresses
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, it is not needed. I will remove it.
Description
Created simplifies custom BC GeoAddress component generates full address and coordinates. Users can use this component as an alternative to BC Address Component, which generates a huge output.
Types of changes
New feature (non-breaking change which adds functionality)
Checklist
Further comments