Forms-396_filter_bc_geo_address_output #874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed-form-service into FORMS-396_Filter_BC_GeoAddress_Output
Forms 396 filter bc geo address output
Coverage Report (Application)
|
Coverage Report (Frontend)
|
Update app.dc.yaml
relative path test
change url path to relative path
Update action.yaml
Update action.yaml
test relative path
test url relative path
test relative url
relative path checks
Update action.yaml
…ed-form-service into FORMS-396_Filter_BC_GeoAddress_Output
…ed-form-service into FORMS-396_Filter_BC_GeoAddress_Output
update branch with upstream master branch
…omponent Removed the Address 1, Address 2, City, Country, Province and Postal textfields from both BC Address Component and Simple BC Address Component
remove unused textfields
Removed disabled property from both BC Address and Simple BC Address response property and display value property
removed disabled property
bcvesalink
reviewed
Jul 17, 2023
| let searchAddresses = await geoAddressService.addressQuerySearch(query); | ||
|
|
||
| if (searchAddresses?.features && Array.isArray(searchAddresses.features)) { | ||
| await searchAddresses.features.forEach((element) => { |
There was a problem hiding this comment.
@timisenco2015 why would we need await here?
There was a problem hiding this comment.
It was returning empty addresses
There was a problem hiding this comment.
Actually, it is not needed. I will remove it.
bcvesalink
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Created simplifies custom BC GeoAddress component generates full address and coordinates. Users can use this component as an alternative to BC Address Component, which generates a huge output.
Types of changes
New feature (non-breaking change which adds functionality)
Checklist
Further comments