Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SubmissionsTable.vue #872

Merged
merged 2 commits into from
Jul 12, 2023
Merged

Update SubmissionsTable.vue #872

merged 2 commits into from
Jul 12, 2023

Conversation

timisenco2015
Copy link
Contributor

Description

I moved this line on code "this.showColumnsDialog = false" to the first line in the method so that the select column dialog box will close faster.

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have run the npm script lint on the frontend and backend
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have approval from the product owner for the contribution in this pull request

Further comments

I moved this line on code "this.showColumnsDialog = false" to the first line in the method so that the select column dialog box will close faster.
Update SubmissionsTable.vue
@github-actions
Copy link

Coverage Report (Application)

Totals Coverage
Statements: 40.36% ( 2369 / 5870 )
Methods: 35.46% ( 295 / 832 )
Lines: 46.3% ( 1613 / 3484 )
Branches: 29.67% ( 461 / 1554 )

@github-actions
Copy link

Coverage Report (Frontend)

Totals Coverage
Statements: 70.03% ( 1054 / 1505 )
Methods: 66.9% ( 188 / 281 )
Lines: 74.42% ( 736 / 989 )
Branches: 55.32% ( 130 / 235 )

@timisenco2015 timisenco2015 merged commit 76616eb into master Jul 12, 2023
11 checks passed
@timisenco2015 timisenco2015 deleted the quick-fix branch August 14, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants