Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance export API endpoint (#840) #858

Merged
merged 2 commits into from
Jul 11, 2023

Conversation

ptugger
Copy link
Contributor

@ptugger ptugger commented Jul 10, 2023

  • Ticket 14703 - Enhance Export API in CHEFS to support filtering based on status and updates

  • Modifications to Export API endpoint to limit user to use allowed columns only

  • Ticket 14703 - Enhance Export API in CHEFS to support filtering based on status and updates

  • Modifications to Export API endpoint to limit user to use allowed columns only

  • Fix issue when single column supplied and fix migration

  • Added Unit Tests

  • Buggy Test _getSubmissions included

  • unit test add for submissionData filterUpdatedAt filter

  • Work in progress for unit tests-pending

  • Added more unit tests for _getSubmissions function that covers with and without preferences

  • Removed unwanted console statements

  • Removed package file from root

  • Test:Enhance Export API for ETL (Test:Enhance Export API for ETL #790)

  • Ticket 14703 - Enhance Export API in CHEFS to support filtering based on status and updates

  • Modifications to Export API endpoint to limit user to use allowed columns only

  • Fix issue when single column supplied and fix migration

  • Added Unit Tests

  • Buggy Test _getSubmissions included

  • unit test add for submissionData filterUpdatedAt filter

  • Work in progress for unit tests-pending

  • Added more unit tests for _getSubmissions function that covers with and without preferences

  • Removed unwanted console statements

  • Removed package file from root


  • Added status as param into Export api to filter submissions by Status

  • Updated Unit tests

  • Added documentation param

  • Removed commented statement (Reviewed)


Description

Enhance Export API in CHEFS to support filtering based on status and updates, Added new column query parameter to accept new columns to fetch like updatedAt, deleted or draft. Added new migration file to modify view to add new updatedAt column. change documentation.

Types of changes

New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have run the npm script lint on the frontend and backend
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have approval from the product owner for the contribution in this pull request

Further comments

* Ticket 14703 - Enhance Export API in CHEFS to support filtering based on status and updates

* Modifications to Export API endpoint to limit user to use allowed columns only

* Ticket 14703 - Enhance Export API in CHEFS to support filtering based on status and updates

* Modifications to Export API endpoint to limit user to use allowed columns only

* Fix issue when single column supplied and fix migration

* Added Unit Tests

* Buggy Test _getSubmissions included

* unit test add for submissionData filterUpdatedAt filter

* Work in progress for unit tests-pending

* Added more unit tests for _getSubmissions function that covers with and without preferences

* Removed unwanted console statements

* Removed package file from root

* Test:Enhance Export API for ETL (#790)

* Ticket 14703 - Enhance Export API in CHEFS to support filtering based on status and updates

* Modifications to Export API endpoint to limit user to use allowed columns only

* Fix issue when single column supplied and fix migration

* Added Unit Tests

* Buggy Test _getSubmissions included

* unit test add for submissionData filterUpdatedAt filter

* Work in progress for unit tests-pending

* Added more unit tests for _getSubmissions function that covers with and without preferences

* Removed unwanted console statements

* Removed package file from root

---------

Co-authored-by: bigvaimarcella <[email protected]>

* Added status as param into Export api to filter submissions by Status

* Updated Unit tests

* Added documentation param

* Removed commented statement (Reviewed)

---------

Co-authored-by: bigvaimarcella <[email protected]>
@github-actions
Copy link

Coverage Report (Application)

Totals Coverage
Statements: 40.36% ( 2369 / 5870 )
Methods: 35.46% ( 295 / 832 )
Lines: 46.3% ( 1613 / 3484 )
Branches: 29.67% ( 461 / 1554 )

@github-actions
Copy link

Coverage Report (Frontend)

Totals Coverage
Statements: 70.11% ( 1053 / 1502 )
Methods: 66.9% ( 188 / 281 )
Lines: 74.54% ( 735 / 986 )
Branches: 55.32% ( 130 / 235 )

@bcgov-citz-ccft bcgov-citz-ccft merged commit 09939f1 into master Jul 11, 2023
11 checks passed
@bcgov-citz-ccft bcgov-citz-ccft deleted the enhance-export-api_updated branch July 11, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants