Right to left (RTL) direction support #833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right to left (RTL) direction support
Coverage Report (Application)
|
Coverage Report (Frontend)
|
add RTL to about.vue
Fixed alignment issues in FormDesigner.vue Fixed alignment issues in ApiKey.vue Fixed alignment issues in ManageVersions.vue
…ed-form-service into chefs_rtl_supports
…ed-form-service into chefs_rtl_supports
fix alignment issues with RTL languages support
WalterMoar
reviewed
Jul 18, 2023
WalterMoar
reviewed
Jul 18, 2023
WalterMoar
reviewed
Jul 18, 2023
This comment was marked as resolved.
This comment was marked as resolved.
|
I noticed a RTL bug that isn't part of the PR but maybe it's an easy fix? On the Admin page Forms table, the created date is displaying "DATE TIME AM/PM - USER" for LTR but for RTL it's "AM/PM - USER TIME DATE": 
Not sure how this is supposed to display in RTL! :) I'm thinking just reversing the order of the items probably isn't correct? |
WalterMoar
reviewed
Jul 18, 2023
WalterMoar
reviewed
Jul 18, 2023
WalterMoar
reviewed
Jul 18, 2023
WalterMoar
reviewed
Jul 18, 2023
WalterMoar
reviewed
Jul 18, 2023
fix PR review suggested changes
fix wrong error message in create.vue
WalterMoar
reviewed
Jul 20, 2023
WalterMoar
reviewed
Jul 20, 2023
WalterMoar
reviewed
Jul 20, 2023
WalterMoar
reviewed
Jul 20, 2023
WalterMoar
reviewed
Jul 20, 2023
WalterMoar
reviewed
Jul 20, 2023
WalterMoar
reviewed
Jul 20, 2023
WalterMoar
reviewed
Jul 20, 2023
app/frontend/src/components/forms/submission/ManageSubmissionUsers.vue
Outdated
Show resolved
Hide resolved
WalterMoar
reviewed
Jul 20, 2023
WalterMoar
reviewed
Jul 20, 2023
WalterMoar
reviewed
Jul 20, 2023
fix RTL align Preview.vue and others
WalterMoar
reviewed
Jul 20, 2023
WalterMoar
reviewed
Jul 20, 2023
general review and fixing alignment issue with RTL
fix language selection drop menu height in home page
remove span from ul li tags in FormDisclaimer
- remove rtl support for vuetify v-switch - remove pu language code
remove rtl support for vuetify v-switch
jasonchung1871
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some languages, such as Persian, Hindi, and Arabic, support writing from right to left instead of the traditional left to right. This feature will enable CHEFS to support languages that write from right to left.
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist
Further comments