Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address sampling #16

Open
wants to merge 11 commits into
base: remoteness
Choose a base branch
from
Open

Address sampling #16

wants to merge 11 commits into from

Conversation

jonjunduan
Copy link
Contributor

Add a qmd file to do the sampling process.

@lindsay-fredrick
Copy link
Contributor

Hey @jonjunduan - I see that you've added a qmd, as well as all of the associated html/css files that get produced when you render a qmd file. Do you think you could remove all the extra html related files, and then add them to the gitignore? (I think it's the html file, as well as the Address_sampling_files folder). Typically we don't want rendered final content in github (not only because we don't want report stuff in github, but also because it makes a PR super messy when all those files get accidentally included).

@thister
Copy link
Contributor

thister commented Jan 6, 2025

There are two .gitignores now -- one in the home folder and another in /src. Is this desirable?

@lindsay-fredrick
Copy link
Contributor

There are two .gitignores now -- one in the home folder and another in /src. Is this desirable?

It's okay to have more than one, sometimes it's just easier to have one directly in a folder to ignore things there.

@thister
Copy link
Contributor

thister commented Jan 6, 2025

Okay - good to know there are different strategies to ignore things (I wish this generalized to life).

Next question: What is the "ultimate purpose" of this .qmd file? I ask because there are, for example, some somewhat minor formatting issues in the text - should I address them? Or do we mostly just care about the code?

@jonjunduan
Copy link
Contributor Author

Okay - good to know there are different strategies to ignore things (I wish this generalized to life).

Next question: What is the "ultimate purpose" of this .qmd file? I ask because there are, for example, some somewhat minor formatting issues in the text - should I address them? Or do we mostly just care about the code?

Both are needed, but the key goal is to verify the approach to create good samples for the remoteness calculation. We may also need to find the best parameters in the sampling process.

@thister
Copy link
Contributor

thister commented Jan 6, 2025

Okay - good to know there are different strategies to ignore things (I wish this generalized to life).
Next question: What is the "ultimate purpose" of this .qmd file? I ask because there are, for example, some somewhat minor formatting issues in the text - should I address them? Or do we mostly just care about the code?

Both are needed, but the key goal is to verify the approach to create good samples for the remoteness calculation. We may also need to find the best parameters in the sampling process.

Okay - I'll be ruthless then =)

@lindsay-fredrick
Copy link
Contributor

@jonjunduan I'm a bit confused by this entire PR - the majority of the qmd appears to be methodology documentation for a possible sampling strategy that could be used by another team to re-build a metric that we are considering using in the SES? Why are we building a sampling strategy for a single small measure in our SES in our SES repo? (especially if we aren't even building the metric ourselves)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants