ALCS-2325 Tag/Category entities and cruds #1937
Merged
+794
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
fbarreta
commented
Oct 24, 2024
fbarreta
commented
- Created Category and Tag entities
- Basic API CRUD functions
Abradat
reviewed
Oct 24, 2024
services/apps/alcs/src/alcs/admin/tag-category/tag-category.controller.spec.ts
Show resolved
Hide resolved
services/apps/alcs/src/alcs/admin/tag-category/tag-category.service.spec.ts
Show resolved
Hide resolved
| return await this.service.create(createDto); | ||
| } | ||
|
|
||
| @Put('/:uuid') |
There was a problem hiding this comment.
It looks like in the downstream service you are updating only one field of the entity which is the name. Since it is a partial update, would it be better to use PATCH request instead of PUT?
Abradat
reviewed
Oct 24, 2024
| return await this.service.create(createDto); | ||
| } | ||
|
|
||
| @Put('/:uuid') |
There was a problem hiding this comment.
Tag Category Controller is now using PATCH request for updating. Since both seem to be partial update, do you want to change this one to PATCH to be aligned?
|
Looking good overall! Impressed you took on such an ambitious ticket this early. My only sort of general comment would be to use more type annotations in the services and controllers. I feel like the majority of the issues I encounter day-to-day are due to ambiguous typing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.