Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All - UI: add sbc web messenger #450

Merged
merged 13 commits into from
Jan 13, 2025
Merged

All - UI: add sbc web messenger #450

merged 13 commits into from
Jan 13, 2025

Conversation

deetz99
Copy link
Collaborator

@deetz99 deetz99 commented Jan 11, 2025

Issue:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the BC Registry and Digital Services BSD 3-Clause License

@dimak1
Copy link
Collaborator

dimak1 commented Jan 11, 2025

@deetz99 still draft or ready for review?

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-examiner-dev--pr-450-7w5r1k2m.web.app

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-strata-hotel-dev--pr-450-btj0lb4f.web.app

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-hosts-dev--pr-450-lj1zzpn4.web.app

@deetz99 deetz99 marked this pull request as ready for review January 13, 2025 18:47
@deetz99
Copy link
Collaborator Author

deetz99 commented Jan 13, 2025

@deetz99 still draft or ready for review?

ready now

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-examiner-dev--pr-450-7w5r1k2m.web.app

@deetz99 deetz99 changed the title sbc messenger draft All - UI: add sbc web messenger Jan 13, 2025
@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-strata-hotel-dev--pr-450-btj0lb4f.web.app

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-hosts-dev--pr-450-lj1zzpn4.web.app

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-examiner-dev--pr-450-7w5r1k2m.web.app

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-strata-hotel-dev--pr-450-btj0lb4f.web.app

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-platform-dev--pr-450-uf5mv4cg.web.app

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-hosts-dev--pr-450-lj1zzpn4.web.app

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-hosts-dev--pr-450-lj1zzpn4.web.app

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-examiner-dev--pr-450-7w5r1k2m.web.app

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-platform-dev--pr-450-uf5mv4cg.web.app

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-strata-hotel-dev--pr-450-btj0lb4f.web.app

Copy link
Collaborator

@kialj876 kialj876 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

# vaults sbc/genesys messenger
NUXT_GENESYS_URL=""
NUXT_GENESYS_ENVIRONMENT_KEY=""
NUXT_GENESYS_DEPLOYMENT_KEY=""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these need to be created in 1pass? I can do that for you if you need

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that would be great if you could. I can wait to merge this until thats added.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
8.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-examiner-dev--pr-450-7w5r1k2m.web.app

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-strata-hotel-dev--pr-450-btj0lb4f.web.app

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-platform-dev--pr-450-uf5mv4cg.web.app

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-hosts-dev--pr-450-lj1zzpn4.web.app

@deetz99 deetz99 merged commit 8d1383f into bcgov:main Jan 13, 2025
42 of 43 checks passed
@deetz99 deetz99 deleted the sbc-msg-draft branch January 13, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants